-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds basic federation status health check #35
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems to work pretty well
|
markgoddard
reviewed
Nov 18, 2024
It might also be nice to add the federation list command to the federation integration test. |
Added this post deploy fn as it feels like we might add to these sorts of post-deploy commands down the line cofidectl/tests/integration/federation/test.sh Lines 81 to 86 in 49fecb2
|
markgoddard
reviewed
Nov 21, 2024
Co-authored-by: Mark Goddard <[email protected]>
markgoddard
reviewed
Nov 21, 2024
markgoddard
reviewed
Nov 22, 2024
markgoddard
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a simple check for a given Federation pair, ensuring equality between the bundles on both sides. For each trust zone it will:
/opt/spire/bin/spire-server bundle show
)/opt/spire/bin/spire-server bundle list
)Note this currently relies on a bump to
go 1.23
to make use ofslices.Chunk
This might not be the full story for federation health. We could feasibly check:
ClusterFederatedTrustDomain
entries on both sidesClusterSPIFFEID
FederatesWith
values on both sides (although we'd need to specify which ones to check, perhaps via boundattestation-policy
entries?)attest-me
pattern as mooted in previous discussions