Full dependency tree rewrite #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is very much inspired by #10 by @costasovo, but I eventually landed on a different approach, using recursion. This allows for virtually no limits in the depth of the dependency tree.
I've also settled on removing the ability to disable processing dependencies, as that is beyond the scope of this project. If a package has a dependency, it needs to be processed as well, in order to maintain the bundled, prefixed dependencies in WordPress plugins.
I'd like some testing on this pull request before I release it - any feedback is greatly appreciated! 😄
This pull request eventually closes #1.