Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dependency tree of packages #10

Closed
wants to merge 6 commits into from

Conversation

costasovo
Copy link

@costasovo costasovo commented Oct 17, 2018

I've added an option--with_dependencies for the compose command. When the command runs without the option it does nothing to sub-deps and it works same as current version.

When the command runs it process all installed sub-dependencies of a package (required and suggested) as if they were listed in mozart config. (commit)

After moving all dependencies it replaces sub-dependency namespaces or classnames within parent dependency package. (commit)

Closes #1

@coenjacobs
Copy link
Owner

Thanks a lot @costasovo, this looks amazing already. I’m going to put it through intensive testing this week and will get back to it then. One thing that stands out to me right away is that I’d rather have the dependency tree flag default to true, making it the default behavior. I can’t think of many use cases where I’d leave this off, but it’s nice to have an option to do so for debugging purposes.

@costasovo
Copy link
Author

Good point about making it a default option. I will update the PR.

@costasovo
Copy link
Author

I've added a commit which changes the option to --skip_dependencies and the compose command processes sub-dependencies by default.

@costasovo
Copy link
Author

I've found out that it was not a good idea to process all installed suggested dependencies automatically since there could be a situation when two packages share dependency (one as required and one as suggested) and then the suggested one will be always processed.
I've added a commit which changes that. Suggested deps now have to be mentioned in mozart config to be processed.

@coenjacobs
Copy link
Owner

coenjacobs commented Jan 31, 2019

Thanks again @costasovo for working on this. I've just pushed my own take on processing the dependency tree in #12. Could you have a look there? Now only I need a way to give you official props on the project, if we don't go ahead with merging this PR, because your code inspired me big time. 😄

@coenjacobs
Copy link
Owner

I have released my solution to this problem in release 0.3.0, where I've given you credits, @costasovo - thanks a lot again! 🎉

@coenjacobs coenjacobs closed this Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants