-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support dependency tree of packages #10
Conversation
Thanks a lot @costasovo, this looks amazing already. I’m going to put it through intensive testing this week and will get back to it then. One thing that stands out to me right away is that I’d rather have the dependency tree flag default to |
Good point about making it a default option. I will update the PR. |
I've added a commit which changes the option to |
I've found out that it was not a good idea to process all installed suggested dependencies automatically since there could be a situation when two packages share dependency (one as required and one as suggested) and then the suggested one will be always processed. |
Thanks again @costasovo for working on this. I've just pushed my own take on processing the dependency tree in #12. Could you have a look there? Now only I need a way to give you official props on the project, if we don't go ahead with merging this PR, because your code inspired me big time. 😄 |
I have released my solution to this problem in release 0.3.0, where I've given you credits, @costasovo - thanks a lot again! 🎉 |
I've added an option--with_dependencies
for the compose command. When the command runs without the option it does nothing to sub-deps and it works same as current version.When the command runs it process all installed sub-dependencies of a package (required and suggested) as if they were listed in mozart config. (commit)
After moving all dependencies it replaces sub-dependency namespaces or classnames within parent dependency package. (commit)
Closes #1