Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(karma-webpack): normalize file.path (windows) #354

Merged
merged 1 commit into from
Sep 7, 2018
Merged

fix(karma-webpack): normalize file.path (windows) #354

merged 1 commit into from
Sep 7, 2018

Conversation

Teamop
Copy link
Contributor

@Teamop Teamop commented Sep 7, 2018 •
edited by michael-ciniawsky
Loading

Based on my test, this place still needs to add normalize

Type

  • Fix

Issues

SemVer

  • Patch

@Teamop Teamop mentioned this pull request Sep 7, 2018
Merged
2 tasks
@michael-ciniawsky michael-ciniawsky changed the title fix(karma-webpack): normalize paths (windows) fix(karma-webpack): normalize file.path (windows) Sep 7, 2018
michael-ciniawsky
michael-ciniawsky approved these changes Sep 7, 2018
View reviewed changes
Copy link
Contributor

@michael-ciniawsky michael-ciniawsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx 👍

@michael-ciniawsky michael-ciniawsky added this to the 3.0.4 milestone Sep 7, 2018
@michael-ciniawsky michael-ciniawsky merged commit 855e21c into codymikol:3.0.0 Sep 7, 2018
@michael-ciniawsky
Copy link
Contributor

Released in v3.0.4 🎉

@michael-ciniawsky michael-ciniawsky removed this from the 3.0.5 milestone Sep 7, 2018
This was referenced Sep 7, 2018
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-ciniawsky michael-ciniawsky michael-ciniawsky approved these changes

Assignees
No one assigned
Labels
semver: Patch status: Approved type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Teamop @michael-ciniawsky