fix(karma-webpack): normalize paths (`windows`) #351

Teamop · 2018-09-03T16:09:04Z

With #347 changes, now get error: TypeError: Path must be a string. Received undefined. After my research, there are 3 places will throw this error:

Two in the readFile, L311, L337, both are this.outputs.get(file)
--- the changes I made here is to map the file path to the entry path, so that can getting the file from the outputs. Example, changes from test\unit\karma-test-shim to test/unit/karma-test-shim
One in the createPreprocesor L386, this line webpackPlugin.outputs.get(filename);
--- for this one, the file is already the real file path, if replaced with the webpack stats one, the karma web server cannot find the file 404.
Example here, changes from C:/project/test/unit/karma-test-shim.js to C:\project\test\unit\karma-test-shim.js

Type

Fix

Issues

Fixes TypeError: Path must be a string. Received [ 'js/main.spec.js', #350

SemVer

Patch

ryanclark · 2018-09-03T16:54:56Z

src/karma-webpack.js

@@ -383,9 +387,6 @@ function createPreprocesor(/* config.basePath */ basePath, webpackPlugin) {
        throw err;
      }

-      const outputPath = webpackPlugin.outputs.get(filename);
-      file.path = path.join(basePath, outputPath);


How comes you removed this? It's needed to rewrite the asset path for karma to point to .js if the file extension was .ts for example

okay, but with this, just for simple js file, the karma web server will not find the file and throw 404

I tried to rewrite the file path like the above, but failed, so what do you think here should to do?

Hi @rynclark , I tried to add this code back when testing with .ts file, but there's a problem, here path.join(basePath, outputPath) refers to the absolute path in the file system, so that 404, because .js doesn't exist at this basePath, so when replacing with path same aswebpackOptions.output.path = path.join(os.tmpdir(), '_karma_webpack_', indexPath, '/');, still cannot find the compiled .js file

Could we move discussion about this into another PR and first of all fix the file path normalization issue as this seems to be critical?

I tried with v3.0.3, still needs this L393 changes which normalizes the path again. I have opened a PR #354 for 3.0. @michael-ciniawsky

this PR is ready, with this changs, I have no issues.

Sry 🙏 I skipped over https://github.com/webpack-contrib/karma-webpack/pull/351/files#r215968728

np, thanks @michael-ciniawsky

thijstriemstra · 2018-09-03T19:11:34Z

Seeing similar error after upgrading to RC1:

03 09 2018 20:55:24.766:ERROR [karma]: TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string
    at assertPath (path.js:39:11)
    at Object.join (path.js:1158:7)
    at Plugin.<anonymous> (/home/foo/projects/bar/node_modules/karma-webpack/lib/karma-webpack.js:284:70)
    at Plugin.readFile (/home/foo/projects/bar/node_modules/karma-webpack/lib/karma-webpack.js:303:5)
    at process._tickCallback (internal/process/next_tick.js:176:11)

michael-ciniawsky · 2018-09-06T15:57:29Z

src/karma-webpack.js

@@ -308,7 +308,7 @@ Plugin.prototype.readFile = function(file, callback) {
              os.tmpdir(),
              '_karma_webpack_',
              String(idx),
-              this.outputs.get(file)
+              this.outputs.get(file.replace(/\\/g, '/'))


Please move this into it's own helper

const normalize = (file) => file.replace(/\\/g, '/')

michael-ciniawsky · 2018-09-06T15:59:44Z

src/karma-webpack.js

@@ -383,9 +387,6 @@ function createPreprocesor(/* config.basePath */ basePath, webpackPlugin) {
        throw err;
      }

-      const outputPath = webpackPlugin.outputs.get(filename);
-      file.path = path.join(basePath, outputPath);


Could we move discussion about this into another PR and first of all fix the file path normalization issue as this seems to be critical?

michael-ciniawsky

@Teamop 👍 Thx

src/karma-webpack.js

@@ -383,9 +387,6 @@ function createPreprocesor(/* config.basePath */ basePath, webpackPlugin) {
        throw err;
      }

-      const outputPath = webpackPlugin.outputs.get(filename);
-      file.path = path.join(basePath, outputPath);


michael-ciniawsky · 2018-09-07T15:21:14Z

Released in 4.0.0-rc.2 🎉

fix(karma-webpack): fix output assets path

abf8e61

Teamop mentioned this pull request Sep 3, 2018

Karma webpack hangs on the Compiled successfully statement when wepback optimization is set #322

Closed

ryanclark reviewed Sep 3, 2018

View reviewed changes

43081j mentioned this pull request Sep 6, 2018

TypeError: Path must be a string. Received [ 'js/main.spec.js', #350

Closed

michael-ciniawsky suggested changes Sep 6, 2018

View reviewed changes

michael-ciniawsky changed the title ~~fix(karma-webpack): fix output assets path~~ fix(karma-webpack): normalize asset paths Sep 6, 2018

michael-ciniawsky added type: Bug severity: 2 (regression) priority: 2 (urgent) pr_action: Rework semver: Patch labels Sep 6, 2018

michael-ciniawsky added this to the 4.0.0 milestone Sep 6, 2018

edmorley mentioned this pull request Sep 6, 2018

Update dependency karma-webpack to v4.0.0-rc.3 neutrinojs/neutrino#1065

Merged

michael-ciniawsky changed the title ~~fix(karma-webpack): normalize asset paths~~ fix(karma-webpack): normalize paths (windows) Sep 7, 2018

fix(karma-webpack): normalize asset paths

eae102e

michael-ciniawsky approved these changes Sep 7, 2018

View reviewed changes

src/karma-webpack.js

@@ -383,9 +387,6 @@ function createPreprocesor(/* config.basePath */ basePath, webpackPlugin) {

throw err;

}

const outputPath = webpackPlugin.outputs.get(filename);

file.path = path.join(basePath, outputPath);

This comment was marked as resolved.

Sign in to view

michael-ciniawsky merged commit 2145ec2 into codymikol:master Sep 7, 2018

michael-ciniawsky added status: Approved and removed pr_action: Rework priority: 2 (urgent) severity: 2 (regression) labels Sep 7, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(karma-webpack): normalize paths (`windows`) #351

fix(karma-webpack): normalize paths (`windows`) #351

Teamop commented Sep 3, 2018 •

edited by michael-ciniawsky

Loading

ryanclark Sep 3, 2018

Teamop Sep 3, 2018

Teamop Sep 3, 2018

Teamop Sep 4, 2018

michael-ciniawsky Sep 6, 2018

Teamop Sep 7, 2018 •

edited

Loading

This comment was marked as resolved.

Teamop Sep 7, 2018

michael-ciniawsky Sep 7, 2018

Teamop Sep 7, 2018

thijstriemstra commented Sep 3, 2018

michael-ciniawsky Sep 6, 2018 •

edited

Loading

michael-ciniawsky Sep 6, 2018

michael-ciniawsky left a comment

This comment was marked as resolved.

michael-ciniawsky commented Sep 7, 2018

fix(karma-webpack): normalize paths (windows) #351

fix(karma-webpack): normalize paths (windows) #351

Conversation

Teamop commented Sep 3, 2018 • edited by michael-ciniawsky Loading

Type

Issues

SemVer

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Teamop Sep 7, 2018 • edited Loading

Choose a reason for hiding this comment

This comment was marked as resolved.

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

thijstriemstra commented Sep 3, 2018

michael-ciniawsky Sep 6, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

michael-ciniawsky left a comment

Choose a reason for hiding this comment

This comment was marked as resolved.

michael-ciniawsky commented Sep 7, 2018

fix(karma-webpack): normalize paths (`windows`) #351

fix(karma-webpack): normalize paths (`windows`) #351

Teamop commented Sep 3, 2018 •

edited by michael-ciniawsky

Loading

Teamop Sep 7, 2018 •

edited

Loading

michael-ciniawsky Sep 6, 2018 •

edited

Loading