Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update atlas lockfile for new version #89

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Conversation

elcritch
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Dec 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (beefafc) 84.06% compared to head (f652cde) 84.06%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #89   +/-   ##
=======================================
  Coverage   84.06%   84.06%           
=======================================
  Files          25       25           
  Lines        4310     4310           
=======================================
  Hits         3623     3623           
  Misses        687      687           
Flag Coverage Δ
unittests 84.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elcritch
Copy link
Contributor Author

@gmega you should use this. It updates the lockfile to the new format and adds url rules for the various package moves.

I tried moving the workspace to be the project folder too, but it looks like I found another atlas bug generating lockfiles. That's when the workspace is in the same folder as the current project. Hmmm, I'll need to fix that too, but atlas pin seems to work fine when it's setup as a sub-dir workspace.

@elcritch
Copy link
Contributor Author

Also, see nim-lang/atlas#93 for the lockfile-in-the-same-place-as-the workspace issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant