Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

atlas pin doesn't work when the workspace is in the current project #93

Open
elcritch opened this issue Dec 22, 2023 · 1 comment
Open

Comments

@elcritch
Copy link
Contributor

Found this bug updating one of my earlier projects with a lockfile. Looks like instead of using the URL, atlas for some reason falls back to the local dir.

I plan to add some integration tests for lockfiles as I don't believe we have any currently. Or if we do, there needs to be more.

Expected lockfile:

{
  "items": {
    "stew": {
      "dir": "$deps/nim-stew",
      "url": "https://github.com/status-im/nim-stew",
      "commit": "7afe7e3c070758cac1f628e4330109f3ef6fc853",
      "version": "0.1.0"
    },
    ...
}

But getting:

  "items": {
    "stint": {
      "dir": "$deps/nim-stint",
      "url": "file:///Users/jaremycreechley/projs/status/nim-codex-dht/vendor/nim-stint",
      "commit": "86621eced1dcfb5e25903019ebcfc76ed9128ec5",
      "version": "0.0.1"
    },
    ...
}
@elcritch
Copy link
Contributor Author

I'll probably not get to this for a couple of weeks with holidays, and travel coming up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant