-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(client): prevent add route into the main page browser history #407
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 79b9b15:
|
Size changessandpack-react
Details
sandpack-client
Details
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, don't think this will have any unwanted side-effects
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Problem:
The iframe assigns a new URL in a manner that adds a new entry to the browser's list of visited URLs, on Firefox.
Solution:
So, instead of manipulating the iframe dom and adding/removing the
src
attribute, it manipulates the iframe browser history.Fixes #398
Useful links: