fix(client): prevent add route into the main page browser history (#407)

codesandbox · Mar 11, 2022 · 1e5230a · 1e5230a
1 parent 8f27c12
commit 1e5230a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/sandpack-client/src/client.ts b/sandpack-client/src/client.ts
@@ -157,9 +157,12 @@ export class SandpackClient {
       );
     }
 
-    this.iframe.src = options.startRoute
+    const urlSource = options.startRoute
       ? new URL(options.startRoute, this.bundlerURL).toString()
       : this.bundlerURL;
+
+    this.iframe.contentWindow?.location.replace(urlSource);
+
     this.iframeProtocol = new IFrameProtocol(this.iframe, this.bundlerURL);
 
     this.unsubscribeGlobalListener = this.iframeProtocol.globalListen(

diff --git a/sandpack-react/src/contexts/sandpackContext.tsx b/sandpack-react/src/contexts/sandpackContext.tsx
@@ -499,7 +499,7 @@ class SandpackProvider extends React.PureComponent<
     const client = this.clients[clientId];
     if (client) {
       client.cleanup();
-      client.iframe.removeAttribute("src");
+      client.iframe.contentWindow?.location.replace("about:blank");
       delete this.clients[clientId];
     } else {
       delete this.preregisteredIframes[clientId];