Update go to 1.18, k8s to 0.24.2 #393
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #393 +/- ##
=======================================
Coverage 82.22% 82.22%
=======================================
Files 25 25
Lines 3083 3083
=======================================
Hits 2535 2535
Misses 415 415
Partials 133 133 |
| @@ -118,9 +118,3 @@ spec: | |||
| storage: true | |||
| subresources: | |||
| status: {} | |||
| status: | |||
There was a problem hiding this comment.
I wonder why all the status sections have been removed by controller-gen in these YAML files 🤔
There was a problem hiding this comment.
@xcoulon yes, i was thinking the same. For reference - kubernetes-sigs/controller-tools#630 - explains a bit more about the choice of removing status.
ranakan19
requested review from
rajivnathan,
alexeykazakov,
mfrancisc,
michaelkleinhenz and
sbryzak
go.mod
Outdated
|
|
||
| replace ( | ||
| github.com/codeready-toolchain/api v0.0.0-20221121081259-4f672e808b89 => github.com/ranakan19/api v0.0.0-20221201091806-57fc665ce345 | ||
| github.com/codeready-toolchain/toolchain-common v0.0.0-20221117081323-252a38460fa1 => github.com/ranakan19/toolchain-common v0.0.0-20221201182049-e9ceb160687f |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MatousJobanek, mfrancisc, ranakan19, xcoulon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Xavier Coulon <[email protected]>
No description provided.