Update Golang to 1.18 and k8s to 0.24.2 #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ranakan19
commented
Nov 24, 2022
| @@ -1,3 +1,4 @@ | |||
| //go:build tools | |||
There was a problem hiding this comment.
added as result of make lint
ranakan19
commented
Nov 24, 2022
| @@ -21,7 +21,7 @@ define go-get-tool | |||
| cd $${TMP_DIR} ;\ | |||
| go mod init tmp ;\ | |||
| echo "Downloading ${2}" ;\ | |||
| GOBIN=$(PROJECT_DIR)/bin go get ${2}@${3} ;\ | |||
| GOBIN=$(PROJECT_DIR)/bin go install ${2}@${3} ;\ | |||
There was a problem hiding this comment.
make target 'controller-gen' wasn't creating the new version controller-gen when the old one existed. Because with golang 1.17 installing executables with go get is deprecated, changing this script to go install.
For this script to work as expected, local golang should be updated to 1.18 as well.
ranakan19
commented
Nov 24, 2022
| @@ -78,6 +78,7 @@ type NSTemplateSetSpaceRole struct { | |||
| TemplateRef string `json:"templateRef"` | |||
|
|
|||
| // Usernames the usernames to which the template applies | |||
| // +listType=atomic | |||
There was a problem hiding this comment.
added to avoid the following in make generate:
API rule violation: list_type_missing,github.com/codeready-toolchain/api/api/v1alpha1,NSTemplateSetSpaceRole,Usernames
ranakan19
requested review from
xcoulon,
MatousJobanek,
alexeykazakov,
mfrancisc,
rajivnathan and
sbryzak
xcoulon
approved these changes
Nov 25, 2022
|
/retest |
mfrancisc
approved these changes
Dec 2, 2022
MatousJobanek
approved these changes
Dec 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR has changes for the following:
Checks
Did you run
make generatetarget? yesDid
make generatechange anything in other projects (host-operator, member-operator)? yesIn case of new CRD, did you the following? N?A
In case other projects are changed, please provides PR links.