KUBESAW-12: Convert the health-check goroutine into ToolchainCluster controller

[fbm3307]

This is to convert the health-check goroutine into ToolchainCluster controller

The related PRs:

• Toolchain-Common - KUBESAW-12: Convert the health-check goroutine into ToolchainCluster controller toolchain-common#386
• Member-Operator - KUBESAW-12: Convert the health-check goroutine into ToolchainCluster controller member-operator#559

The Other PRs where only Toolchain common dependency is updated

• Toolchain-e2e - KUBESAW-12: Convert the health-check goroutine into ToolchainCluster controller toolchain-e2e#949
• Registration-service - KUBESAW-12: Convert the health-check goroutine into ToolchainCluster controller registration-service#422
• Sandbox-sre - https://github.com/codeready-toolchain/sandbox-sre/pull/1698

[fbm3307]

/test e2e

[fbm3307]

/test e2e

[fbm3307]

/test e2e

[rsoaresd]

Hello @fbm3307,

The last run (1780159346131341312) failed with:

=== RUN   TestToolchainClusterE2E/create_new_ToolchainCluster_based_on_'host'_with_incorrect_data_and_expect_to_be_offline
    awaitility.go:539: waiting for toolchaincluster in namespace 'toolchain-host-16094520' to match criteria
    toolchaincluster_test.go:113: 
        	Error Trace:	/tmp/toolchain-e2e/test/e2e/toolchaincluster_test.go:113
        	Error:      	Received unexpected error:
        	            	timed out waiting for the condition
        	Test:       	TestToolchainClusterE2E/create_new_ToolchainCluster_based_on_'host'_with_incorrect_data_and_expect_to_be_offline
--- FAIL: TestToolchainClusterE2E (124.34s)
    --- PASS: TestToolchainClusterE2E/create_new_ToolchainCluster_based_on_'host'_with_correct_data_and_expect_to_be_ready (2.94s)
    --- FAIL: TestToolchainClusterE2E/create_new_ToolchainCluster_based_on_'host'_with_incorrect_data_and_expect_to_be_offline (121.39s)

When looking at this PR history, we can observe that 1778725233843245056 failed with the same error. The other runs related to this PR failed due to infra issues.

From this search query, we can see that happens only in this PR. So, very likely is PR specific. Hope it helps :)

[fbm3307]

Hello @fbm3307,

The last run (1780159346131341312) failed with:

=== RUN   TestToolchainClusterE2E/create_new_ToolchainCluster_based_on_'host'_with_incorrect_data_and_expect_to_be_offline
    awaitility.go:539: waiting for toolchaincluster in namespace 'toolchain-host-16094520' to match criteria
    toolchaincluster_test.go:113: 
        	Error Trace:	/tmp/toolchain-e2e/test/e2e/toolchaincluster_test.go:113
        	Error:      	Received unexpected error:
        	            	timed out waiting for the condition
        	Test:       	TestToolchainClusterE2E/create_new_ToolchainCluster_based_on_'host'_with_incorrect_data_and_expect_to_be_offline
--- FAIL: TestToolchainClusterE2E (124.34s)
    --- PASS: TestToolchainClusterE2E/create_new_ToolchainCluster_based_on_'host'_with_correct_data_and_expect_to_be_ready (2.94s)
    --- FAIL: TestToolchainClusterE2E/create_new_ToolchainCluster_based_on_'host'_with_incorrect_data_and_expect_to_be_offline (121.39s)

When looking at this PR history, we can observe that 1778725233843245056 failed with the same error. The other runs related to this PR failed due to infra issues.

From this search query, we can see that happens only in this PR. So, very likely is PR specific. Hope it helps :)

Hey @rsoaresd Thanks for looking into this, but it passed this time, i dont think it was related to my PR, but it was flaky

[fbm3307]

/test e2e

[MatousJobanek]

Hey @rsoaresd Thanks for looking into this, but it passed this time, i dont think it was related to my PR, but it was flaky

TBH, I haven't seen this error (failed test) ever before. I doubt that it would be an old flaky test. This error seems to be rather caused by the changes in the PR.

[MatousJobanek]

Could you please update the dependency to point to the latest version in your toolchain-common PR?

[MatousJobanek]

👍

[rajivnathan]

👍

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fbm3307, filariow, MatousJobanek, mfrancisc, rajivnathan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [MatousJobanek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[fbm3307]

/test e2e

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[codecov]

Codecov Report

Merging #1010 (e835a91) into master (6a7e692) will increase coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1010      +/-   ##
==========================================
+ Coverage   84.58%   84.60%   +0.02%     
==========================================
  Files          55       55              
  Lines        4852     4852              
==========================================
+ Hits         4104     4105       +1     
+ Misses        575      574       -1     
  Partials      173      173              

see 1 file with indirect coverage changes