KUBESAW-12: Convert the health-check goroutine into ToolchainCluster controller #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…controller Signed-off-by: Feny Mehta <[email protected]>
fbm3307
requested review from
MatousJobanek,
xcoulon,
alexeykazakov,
rajivnathan,
ranakan19,
sbryzak and
mfrancisc
as code owners
|
/test e2e |
filariow
approved these changes
Apr 16, 2024
Signed-off-by: Feny Mehta <[email protected]>
mfrancisc
approved these changes
Apr 17, 2024
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #559 +/- ##
=======================================
Coverage 84.06% 84.06%
=======================================
Files 29 29
Lines 2636 2636
=======================================
Hits 2216 2216
Misses 277 277
Partials 143 143 |
Signed-off-by: Feny Mehta <[email protected]>
Signed-off-by: Feny Mehta <[email protected]>
rajivnathan
approved these changes
Apr 18, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fbm3307, filariow, MatousJobanek, mfrancisc, rajivnathan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Feny Mehta <[email protected]>
|
|
/test e2e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to convert the health-check goroutine into ToolchainCluster controller
The related PRs:
The Other PRs where only Toolchain common dependency is updated