Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish free file releases #1306

Closed
nhooyr opened this issue Jan 28, 2020 · 19 comments
Closed

Publish free file releases #1306

nhooyr opened this issue Jan 28, 2020 · 19 comments
Labels
enhancement Some improvement that isn't a feature

Comments

@nhooyr
Copy link
Contributor

nhooyr commented Jan 28, 2020

nbin is complicated and has caused a significant issues and impedes debugging.

We should publish free file releases for every platform and on the docker container in particular we ought to just not release an nbin based release.

cc @kylecarbs

@nhooyr nhooyr added the enhancement Some improvement that isn't a feature label Jan 28, 2020
@nhooyr nhooyr changed the title Remove nbin from docker container Publish free file releases Jan 28, 2020
@nhooyr
Copy link
Contributor Author

nhooyr commented Jan 28, 2020

Related #529

This was referenced Jan 28, 2020
@nhooyr
Copy link
Contributor Author

nhooyr commented Jan 28, 2020

So we're gonna start release debs/rpms

@nhooyr nhooyr mentioned this issue Jan 29, 2020
@nhooyr
Copy link
Contributor Author

nhooyr commented Jan 29, 2020

So the other issue here is windows support for nbin @kylecarbs

@nhooyr
Copy link
Contributor Author

nhooyr commented Jan 29, 2020

Another annoying problem is the file paths reported are those in CI instead of those on the user's computer, e.g. the typescript version bundled says its in /drone which is confusing.

@sr229
Copy link
Contributor

sr229 commented Jan 30, 2020

AFAIK this is similar to pkg with their snapshot-based file system approach so I think we do save the path since its what the path was during build time.

@orditeck
Copy link

What impact would it have on how easy code-server is easy to upgrade/revert back to previous version?

Right now I download the new binary, exit the old process, run the new binary then check if everything works. If not, I just relaunch the old binary and plan time to look into what's wrong with the new one.

I'm just curious.

Thanks!

@nhooyr
Copy link
Contributor Author

nhooyr commented Jan 30, 2020

Should be just as easy, just have to tar -xzf first.

@orditeck
Copy link

Awesome, so same as right now. Thanks!

@nhooyr
Copy link
Contributor Author

nhooyr commented Feb 3, 2020

nbin def offers nothing, see https://github.com/cdr/code-server/releases

We distribute as zips/tars anyway lol @kylecarbs

@nhooyr
Copy link
Contributor Author

nhooyr commented Feb 3, 2020

We'll also need a Mac DMG and a windows installer.

@nhooyr
Copy link
Contributor Author

nhooyr commented Feb 3, 2020

We're only going to support linux moving forward. See #1332

@nhooyr
Copy link
Contributor Author

nhooyr commented Feb 3, 2020

We're going to add a multi platform installer.

@max-hk
Copy link
Contributor

max-hk commented Feb 5, 2020

We're only going to support linux moving forward. See #1332

Are we going to get Windows release or not?

@sr229
Copy link
Contributor

sr229 commented Feb 5, 2020

We're only going to support linux moving forward. See #1332

Are we going to get Windows release or not?

Based on our CI support, we can't build Windows images, so there won't be a Windows-compatible tarball for your to use at the moment. I suggest using WSL instead to workaround this.

@nhooyr
Copy link
Contributor Author

nhooyr commented Feb 5, 2020

Based on our CI support, we can't build Windows images, so there won't be a Windows-compatible tarball for your to use at the moment. I suggest using WSL instead to workaround this.

Please don't use "we" without consulting myself, @kylecarbs or @code-asher. Us there are the only ones that can make statements on the future of code-server.

We will provide windows releases @MaxLOh with this issue.

This was referenced Feb 14, 2020
code-asher added a commit that referenced this issue Feb 25, 2020
code-asher added a commit that referenced this issue Feb 25, 2020
code-asher added a commit that referenced this issue Feb 26, 2020
@nhooyr
Copy link
Contributor Author

nhooyr commented Mar 5, 2020

@kylecarbs I don't believe this has been taken care of yet, we have no windows release for 3.0.

@nhooyr nhooyr reopened this Mar 5, 2020
@kylecarbs
Copy link
Member

I'm not sure we're ready to provide great support for Windows yet. None of us @cdr develop on Windows, so it feels like a risky thing to provide support. I feel like this issue should be closed with v3.0.0 released.

@nhooyr
Copy link
Contributor Author

nhooyr commented Mar 5, 2020

While I agree it's risky, I think the risk is minimal, especially considering how many times users have asked for it. It's super easy for us to run windows with parallels occasionally to test, we already have a yearly license. nbin was the only blocker for this anyway.

See #259

None of our code is platform specific anyway and VS Code itself supports windows. Same reason why I opted against abandoning Mac support. #1332

Also, we still need a .deb for linux and the npm package. I'll make new issues for those.

@nhooyr
Copy link
Contributor Author

nhooyr commented Mar 5, 2020

Opened a new issue tracking windows.

@nhooyr nhooyr closed this as completed Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Some improvement that isn't a feature
Projects
None yet
Development

No branches or pull requests

5 participants