-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add npm package to make code-server super simple to install #1396
Comments
See #1306 |
Please don't use npm for global binaries. |
Can you elaborate? |
There are better options. In Linux we have apt-get. In macOS and Linux we have Homebrew.
Given all the above, even a shell script would be better. |
I think there's some confusion. This issue isn't about making it the sole way to distribute code-server. We'll still keep our releases, docker images and work towards deb/rpm packages #1395. Having an npm package just reduces friction for users who want to try it out. |
Hello @nhooyr, do you know when this issue might be addressed ? I'd like to install coder on alpine and it seems npm would be the simplest way. |
There's no confusion here. Releasing an npm package just encourages bad practices and there's not a case where it would be easier for your users vs using a proper package manager or a simple install shell script. @micodeyt why bother? Code Server + a reasonable amount of extensions will put you at about 1-2 GB. Support more than one language, and that grows more. At that point, why go through the hassle of using Alpine for your base image to save 7 MB? |
A proper package manager is always better yes, but npm/node is everywhere. Compared to a shell script, you can easily uninstall, list installed global binaries etc and have it already in your $PATH so it is an improvement. We're still moving forward with the Debian releases/repo and a PPA but this will be a nice crutch for when you just want to quickly install. You can test it out now:
|
For me the build is failing on installation. Have you considered installing already built version with npm/yarn? That would also make installation faster. |
@gyzerok Can you try again, it's been merged and in the README.md now: https://github.com/cdr/code-server#npm Re installing build versions with npm/yarn see #1641 |
No description provided.
The text was updated successfully, but these errors were encountered: