Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix tests for permit_empty #6175

Merged
merged 1 commit into from
Jun 24, 2022
Merged

test: fix tests for permit_empty #6175

merged 1 commit into from
Jun 24, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Jun 22, 2022 •
edited
Loading

Description

  • fix tests for permit_empty

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the testing Pull requests that changes tests only label Jun 22, 2022
@kenjis kenjis force-pushed the fix-tests-Validation-permit_empty branch from ab5f21f to 1114668 Compare June 22, 2022 12:27
@kenjis kenjis mentioned this pull request Jun 22, 2022
Open
MGatner
MGatner approved these changes Jun 24, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good

@kenjis kenjis merged commit 08bb4b0 into codeigniter4:develop Jun 24, 2022
@kenjis kenjis deleted the fix-tests-Validation-permit_empty branch June 24, 2022 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
testing Pull requests that changes tests only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @MGatner