Merge pull request #6175 from kenjis/fix-tests-Validation-permit_empty

test: fix tests for permit_empty
codeigniter4 · Jun 24, 2022 · 08bb4b0 · 08bb4b0
2 parents 1188c64 + 1114668
commit 08bb4b0
Showing 1 changed file with 34 additions and 13 deletions.
diff --git a/tests/system/Validation/RulesTest.php b/tests/system/Validation/RulesTest.php
@@ -128,39 +128,60 @@ public function testPermitEmpty(array $rules, array $data, bool $expected): void
     public function providePermitEmptyCases(): Generator
     {
         yield from [
+            // If the rule is only `permit_empty`, any value will pass.
             [
-                ['foo' => 'permit_empty'],
+                ['foo' => 'permit_empty|valid_email'],
                 ['foo' => ''],
                 true,
             ],
             [
-                ['foo' => 'permit_empty'],
+                ['foo' => 'permit_empty|valid_email'],
                 ['foo' => '0'],
-                true,
+                false,
             ],
             [
-                ['foo' => 'permit_empty'],
+                ['foo' => 'permit_empty|valid_email'],
+                ['foo' => '-0'],
+                false,
+            ],
+            [
+                ['foo' => 'permit_empty|valid_emails'],
                 ['foo' => 0],
-                true,
+                false,
+            ],
+            [
+                ['foo' => 'permit_empty|valid_email'],
+                ['foo' => -0],
+                false,
             ],
             [
-                ['foo' => 'permit_empty'],
+                ['foo' => 'permit_empty|valid_email'],
                 ['foo' => 0.0],
-                true,
+                false,
             ],
             [
-                ['foo' => 'permit_empty'],
-                ['foo' => null],
-                true,
+                ['foo' => 'permit_empty|valid_emails'],
+                ['foo' => '0.0'],
+                false,
             ],
             [
-                ['foo' => 'permit_empty'],
-                ['foo' => false],
+                ['foo' => 'permit_empty|valid_email'],
+                ['foo' => -0.0],
+                false,
+            ],
+            [
+                ['foo' => 'permit_empty|valid_email'],
+                ['foo' => '-0.0'],
+                false,
+            ],
+            [
+                ['foo' => 'permit_empty|valid_email'],
+                ['foo' => null],
                 true,
             ],
             [
                 ['foo' => 'permit_empty|valid_email'],
-                ['foo' => ''],
+                ['foo' => false],
                 true,
             ],
             [