-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
495 clear button #530
495 clear button #530
Conversation
- Adds search input manager for handling input clear button—little (x). - Disables autocomplete because field highlight color can’t be overridden. - Removes unused data-list attributes. - Adds tests for clearing the input fields.
- Normalized button and form id/class names using the specificity principle. - Removes unused classes from submit/reset buttons.
Note: This isn't available in IE8, but IE8 support could be added in another PR. An issue for that should be opened when this is merged. It gracefully degrades in IE8 and the clear all button can be used to clear all fields, so it's not a priority to add support. |
@monfresh Ready for review and merge! Thx |
I think autocomplete is too useful a feature to turn off just for cosmetic reasons.
@anselmbradford Reviewed and pushed changes. It looks great, except for turning off autocomplete, which I disagree with. I think autocomplete is too useful a feature to turn off just for cosmetic reasons. I turned it back on in my latest changes and made a fix for asset compilation. |
@monfresh Okay, fair enough. It's not purely aesthetics though, the autocomplete in Chrome makes the yellow background stick when programmatically clearing the input so you can't see the placeholder text anymore: Here's the chromium discussions about it: https://code.google.com/p/chromium/issues/detail?id=46543 I'm trying to find a workaround. |
Weird. I don't see that on my computer. What version of Chrome are you using? |
Ah, I see it now. I wasn't selecting from the autocomplete. Is that just on Chrome? I don't see it in Safari or Firefox. |
Yeah, pretty sure it's just Chrome. |
It's crazy that the bug has been there for 4 years and no one has taken ownership of it. |
I think we can still go ahead with this PR while you find a workaround for Chrome. Let me know if it's good to go and I'll fix conflicts and merge. |
Sounds good. I'll open an issue after it's merged. |
Fixes #495
overridden.
Also:
principle (general --> specific).