Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should individual search fields have an "x" to clear them? #495

Closed
monfresh opened this issue Jul 22, 2014 · 1 comment · Fixed by #530
Closed

Should individual search fields have an "x" to clear them? #495

monfresh opened this issue Jul 22, 2014 · 1 comment · Fixed by #530
Labels
question

Comments

@monfresh
Copy link
Member

@anselmbradford Up until your last style updates in PR #480, you had an "x" at the end of each search field. Is there a reason why you removed it in the end? I think that's a useful feature to have, but maybe it's just me. Looking around on GitHub for example, they don't provide the "x". Is there a best practice on this subject?
@anselmbradford
Copy link
Member

The screenshots were mocks, I thought I might tackle them as part of #480, but seemed better to leave it to #418 because it's not exclusively a style update.

Chrome includes the (x) http://geektnt.com/how-to-remove-x-from-search-input-field-on-chrome-and-ie.html ... but we shouldn't rely on a browser-specific implementation. I think they're worthwhile to include.

anselmbradford added a commit that referenced this issue Jul 29, 2014
@anselmbradford
Fixes #495 - Adds input clear button
84b96c8 
- Adds search input manager for handling input clear button—little (x).
- Disables autocomplete because field highlight color can’t be
overridden.
- Removes unused data-list attributes.
- Adds tests for clearing the input fields.
anselmbradford added a commit that referenced this issue Jul 29, 2014
@anselmbradford
Fixes #495 - Adds input clear button
6c23d00 
- Adds search input manager for handling input clear button—little (x).
- Disables autocomplete because field highlight color can’t be
overridden.
- Removes unused data-list attributes.
- Adds tests for clearing the input fields.
@anselmbradford anselmbradford mentioned this issue Jul 29, 2014
Merged
anselmbradford added a commit that referenced this issue Jul 29, 2014
@anselmbradford
Fixes #495 - Adds input clear button
388b099 
- Adds search input manager for handling input clear button—little (x).
- Disables autocomplete because field highlight color can’t be
overridden.
- Removes unused data-list attributes.
- Adds tests for clearing the input fields.
anselmbradford added a commit that referenced this issue Jul 29, 2014
@anselmbradford
Fixes #495 - Adds input clear button
71b5085 
- Adds search input manager for handling input clear button—little (x).
- Disables autocomplete because field highlight color can’t be
overridden.
- Removes unused data-list attributes.
- Adds tests for clearing the input fields.
anselmbradford added a commit that referenced this issue Jul 29, 2014
@anselmbradford
Fixes #495 - Adds input clear button
042b015 
- Adds search input manager for handling input clear button—little (x).
- Disables autocomplete because field highlight color can’t be
overridden.
- Removes unused data-list attributes.
- Adds tests for clearing the input fields.
anselmbradford added a commit that referenced this issue Jul 29, 2014
@anselmbradford
Fixes #495 - Adds input clear button
ce2abe1 
- Adds search input manager for handling input clear button—little (x).
- Disables autocomplete because field highlight color can’t be
overridden.
- Removes unused data-list attributes.
- Adds tests for clearing the input fields.
anselmbradford added a commit that referenced this issue Jul 29, 2014
@anselmbradford
Fixes #495 - Adds input clear button
3cee227 
- Adds search input manager for handling input clear button—little (x).
- Disables autocomplete because field highlight color can’t be
overridden.
- Removes unused data-list attributes.
- Adds tests for clearing the input fields.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

495 clear button codeforamerica/ohana-web-search
2 participants
@anselmbradford @monfresh