Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FAQ #276

Merged
merged 2 commits into from
Oct 8, 2021
Merged

Add FAQ #276

merged 2 commits into from
Oct 8, 2021

Conversation

F43nd1r
Copy link
Member

@F43nd1r F43nd1r commented Sep 24, 2021

What: Add a FAQ section to the docs. Move kotlin-spring-plugin docs there and add section for GenericFilterBean.

Why: Streamline setup guide, document GenericFilterBean workaround.
Wontfix:
Closes #261
Closes #149
Closes #205

How:
Add new docs section

Checklist:

  • Documentation added
  • N/A Changelog updated
  • N/A Tests added
  • Ready to be merged

@F43nd1r F43nd1r requested a review from WtfJoke September 24, 2021 10:42
@codecov-commenter
Copy link

codecov-commenter commented Sep 24, 2021

Codecov Report

Merging #276 (f566eaa) into main (52ff01d) will increase coverage by 0.62%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #276      +/-   ##
============================================
+ Coverage     75.32%   75.94%   +0.62%     
- Complexity      400      403       +3     
============================================
  Files            80       80              
  Lines          1086     1085       -1     
  Branches         68       68              
============================================
+ Hits            818      824       +6     
+ Misses          223      219       -4     
+ Partials         45       42       -3     
Impacted Files Coverage Δ
...le/chaos/monkey/chaosdemo/RouterConfiguration.java 100.00% <0.00%> (ø)
...ring/boot/chaos/monkey/assaults/MemoryAssault.java 92.85% <0.00%> (+10.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52ff01d...f566eaa. Read the comment docs.

Copy link
Contributor

@WtfJoke WtfJoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks! LGTM 📜

@WtfJoke WtfJoke enabled auto-merge (squash) October 8, 2021 13:58
@WtfJoke WtfJoke merged commit 1f40a5a into codecentric:main Oct 8, 2021
@F43nd1r F43nd1r deleted the faq branch October 22, 2021 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should work with Project Lombok`s logger Exception starting filter [CustomFilter]
3 participants