Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude GenericFilterBean from proxying #261

Closed
wants to merge 3 commits into from

Conversation

F43nd1r
Copy link
Member

@F43nd1r F43nd1r commented Aug 13, 2021

What:
Excludes GenericFilterBean from proxying

Why:
GenericFilterBean will throw an exception when proxied due to a final init method. See also #149 and #205

How:
Blcklist Pointcut to exclude GenericFilterBean

Checklist:

N/A Documentation added

  • Changelog updated
  • N/A Tests added
  • Ready to be merged

@F43nd1r
Copy link
Member Author

F43nd1r commented Aug 13, 2021

This currently fails due to an issue described here https://stackoverflow.com/questions/33136530/target-negation-not-working-in-spring-aop. I'm leaving it at this point today. Further investigation is needed, possibly need to raise the issue with spring aop team.

@F43nd1r
Copy link
Member Author

F43nd1r commented Aug 20, 2021

Now tracking upstream spring-projects/spring-framework#27302

@F43nd1r
Copy link
Member Author

F43nd1r commented Sep 10, 2021

Workaround: Register your class extending GenericFilterBean using @Bean instead of @Component

@F43nd1r F43nd1r mentioned this pull request Sep 24, 2021
2 tasks
@WtfJoke WtfJoke closed this in #276 Oct 8, 2021
@F43nd1r F43nd1r deleted the issue_205 branch October 22, 2021 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should work with Project Lombok`s logger Exception starting filter [CustomFilter]
1 participant