Fix for #257 - Choosing Sunday shows no meetings found. #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The specific issue here is that 11th step meetings store the value "11" as an int in the "types" array instead of a string. This is passed to sanitizeTitle() which tries to apply a regex to the value, and this produces a type error since the value is an int rather than a string. To protect against this specific case and also any other meeting info fields that might have the issue, added conversion to string of the passed value to sanitizeTitle() and sanitizeDataSort().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The specific issue here is that 11th step meetings store the value "11" as an int in the "types" array instead of a string. This is passed to sanitizeTitle() which tries to apply a regex to the value, and this produces a type error since the value is an int rather than a string.
To protect against this specific case and also any other meeting info fields that might have the issue, added conversion to string of the passed value to sanitizeTitle() and sanitizeDataSort().