Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

?tsml-day=0 - Choosing Sunday from drop down shows no meetings found #257

Closed
mrydzfski opened this issue Jan 4, 2021 · 15 comments
Closed
Labels

Comments

@mrydzfski
Copy link

Describe the bug
Good afternoon.

Seeing an issue when choosing SUNDAY from the drop down page, no results are found. Simply refreshing the page then shows the meetings.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://www.upstateintergroup.org/meetings/
  2. Click on DAY - change to SUNDAY
  3. Behold, no results
  4. REFRESH PAGE - Behold, Results.

Using Enfold Theme.
PHP 7.3
WP 5.6 (Just updated today to see if that corrected the issue. It did not. : (
No site cache tools installed

Let me know what else I can do to provide context.

@tech2serve
Copy link
Contributor

I just looked at your complete meeting list and also didn't see any Sunday meetings.

Please check the backend admin page and search for any Sunday meetings in your database. They may be missing.

Let me know.

@mrydzfski
Copy link
Author

mrydzfski commented Jan 4, 2021 via email

@tech2serve
Copy link
Contributor

Ok. Please following the our standing (but not yet documented in one place :-) ) troubleshooting steps. Some of these are:

  1. Disable all other plugins and see if the problem persists. I do see some strange errors in the console when I view your site.
  2. Although you may not have a website caching tool installed, your hosting provider might, and you should check and see if you can clear it.
  3. Confirm you're using the latest version of TSML.
  4. If you're using a child them with customizations, or you have made any customization to TSML or your site, roll those changes back and see if the problem persists.

When did this problem start?

@tech2serve
Copy link
Contributor

Let me add a step that just worked for another user whose entire meeting list wasn't showing up on the front end. Open and republish one of your Sunday meetings. See if that then shows up.

@mrydzfski
Copy link
Author

mrydzfski commented Jan 5, 2021 via email

@tech2serve
Copy link
Contributor

Good write up. Frankly, I can count the number of times we've had a single site issue not get solved by the the steps we discussed above (or similar) on, well, two fingers.

Obviously I'm going to start grasping at straws here. If you're willing, export your meeting data and send it to me via email (tsml at code4recovery dot org). That will help us rule out if it has something to do with the data itself.

And yes, you can try PHP 7.4, but someone else recently tried that and it broke Jetpack and some other plugins. So, if you try it, make sure you can easily roll back.

Another thing you can try is to spin up another site and duplicate the data and plugins over to it. In the past when we've tried this, people have used Docker so we could control the configurations with known community standards. Are you familiar with Docker?

The good news is we are seeing an error (a string is undefined when it shouldn't be) and so we have a place to start. I suspect if we get rid of the error, we'll get rid of the problem.

image

I'm also going to ask some other team members to look at this.

@code4recovery/tsml-contributors

@tech2serve
Copy link
Contributor

tech2serve commented Jan 5, 2021

@mrydzfski, please check out #247, although I'm skeptical.

@mrydzfski
Copy link
Author

mrydzfski commented Jan 5, 2021 via email

@97eighty
Copy link
Contributor

97eighty commented Jan 5, 2021

@mrydzfski Just getting up to speed on this issue. I see that JQMigrate is running on your site. Do you have that installed as a separate plugin or is it built into your theme?

@mrydzfski
Copy link
Author

mrydzfski commented Jan 5, 2021 via email

@mrydzfski
Copy link
Author

Just emailed over the exported data set.

@mrydzfski
Copy link
Author

Also, we found that Enfold has JQMigrate as an option. We toggled that off.

@tech2serve
Copy link
Contributor

Hey @mrydzfski,

Thanks for sending over the data set. Using it, I was able to replicate the issue and determine it is indeed a bug. Not clear exactly where, but I have enough info to go off of, and we should be able to get this fixed for the next release.

Tim

tech2serve pushed a commit that referenced this issue Jan 5, 2021
Some sites have trouble displaying meetings when the 11th Step Meditation
type, being sanitized to create css classes, throws an error because the
11 is an integer instead of a string.

It remains unclear why this only affects a small set of sites.

closes #257
crispyatl added a commit to crispyatl/12-step-meeting-list that referenced this issue Jan 16, 2021
The specific issue here is that 11th step meetings store the value "11" as an int in the "types" array instead of a string.  This is passed to sanitizeTitle() which tries to apply a regex to the value, and this produces a type error since the value is an int rather than a string.

To protect against this specific case and also any other meeting info fields that might have the issue, added conversion to string of the passed value to sanitizeTitle() and sanitizeDataSort().
tech2serve pushed a commit that referenced this issue Jan 22, 2021
Fix:  for #257 - Choosing Sunday shows no meetings found.
@tech2serve
Copy link
Contributor

Hey @mrydzfski

Can you confirm for us that v3.10.0 resolved this issue for you?

@mrydzfski
Copy link
Author

mrydzfski commented Feb 16, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants