Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modification to fix #1898 - Embeds subtitle gives user the option to embed subtitle on screenshot or not #1900

Merged
merged 2 commits into from
Dec 27, 2023

Conversation

WongChoice
Copy link
Contributor

Modification to Fix #1898

What does this PR do?

This is a modification in continuation of PR #1899
Feature added :

  1. Gives user the option to chose if they wish to have subtitle embedded on screenshot or not
    Screenshot2

  2. Appends the caption text in the end of the screenshot file name
    Screenshot 3

@ImprovedTube ImprovedTube merged commit 2d2ee8b into code-charity:master Dec 27, 2023
@ImprovedTube
Copy link
Member

thanks @WongChoice.

edited it to include the subtitle in the file name always.

  • to make this consistent, a final step for this feature can be that our screenshot does this independent of the subtitle being visible on the screen or not.

Please feel free to point me to any PR in future. thanks

there are several pretty relevant ones, that i wont delay if i find team or energy. (Looking forward to your email /requirements)


( also moved your switch here: )
Screenshot_1196
(of course it can be linked at subtitles too /our menu could be dynamic 🤔)

thanks!

ImprovedTube added a commit that referenced this pull request Jan 12, 2024
Modification to fix #1898 - Embeds subtitle gives user the option to embed subtitle on screenshot or not
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can the screenshot function display subtitles in the screenshot?
2 participants