Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Embeds subtitle on saved screenshots #1899

Merged
merged 1 commit into from
Dec 26, 2023
Merged

fix: Embeds subtitle on saved screenshots #1899

merged 1 commit into from
Dec 26, 2023

Conversation

WongChoice
Copy link
Contributor

Fixes #1898

I would like to claim the bounty offered.

What does this PR do?

Adds the feature which embeds subtitle inheriting the subtitle customization from the extension.

Following is the example

Screenshot (9)

@WongChoice WongChoice changed the title fix:Can the screenshot function display subtitles in the screenshot? #1898 fix: Embeds subtitle on saved screenshots Dec 26, 2023
@ImprovedTube ImprovedTube merged commit 06196a2 into code-charity:master Dec 26, 2023
@ImprovedTube
Copy link
Member

hi @WongChoice thank you so much!

bounty

are you avaiable for more work? maybe send an email? whats your hourly rate?

  • i just started using the label #bounty experimentally & we currently receive no donations, yet we should & thats the point, and i can pay some bounties myself to start with...

thanks!

@WongChoice
Copy link
Contributor Author

Hi thank you for merge
thank you so much for bothering to ask.
I would have really appreciated a pay.
At present i have my interests inclined toward ML. Please feel free to point me to any PR in future. thanks

ImprovedTube added a commit that referenced this pull request Jan 12, 2024
fix: Embeds subtitle on saved screenshots
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can the screenshot function display subtitles in the screenshot?
2 participants