streamingest: add a metric for replication cutover progress #96537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
lidorcarmel
force-pushed
the
lidor_cutover_progress_metric
branch
from
3d3cd2c to
1e6af1e
Compare
stevendanna
approved these changes
Feb 7, 2023
dhartunian
approved these changes
Feb 7, 2023
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @adityamaru)
|
@lidorcarmel if you want to you can add this metric to the DBConsole page added in #96206. Can also be a followup! |
followup sg, thanks! |
We already have the progress info in the job as the percentage of ranges that were reverted. This commit adds the number of ranges that are left to be reverted as a metric. Epic: CRDB-18752 Fixes: cockroachdb#96536 Release note: None
lidorcarmel
force-pushed
the
lidor_cutover_progress_metric
branch
from
1e6af1e to
45faeeb
Compare
followup sg, thanks! TFTR all! |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already have the progress info in the job as the percentage of ranges that were reverted. This commit adds the number of ranges that are left to be reverted as a metric.
Epic: CRDB-18752
Fixes: #96536
Release note: None