Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

c2c: add a metric for cutover progress #96536

Closed
lidorcarmel opened this issue Feb 4, 2023 · 1 comment · Fixed by #96537
Closed

c2c: add a metric for cutover progress #96536

lidorcarmel opened this issue Feb 4, 2023 · 1 comment · Fixed by #96537
Assignees
@lidorcarmel
Labels
A-disaster-recovery C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-disaster-recovery

Comments

@lidorcarmel
Copy link
Contributor

lidorcarmel commented Feb 4, 2023 •
edited by exalate-issue-sync bot
Loading

We currently show the cutover progress in the job as a percentage, it would be nice to have a metric that shows the progress, with the number of ranges left to revert.

We can show the number of ranges left to revert during cutover, we have that in the coordinator. To get the number of ranges before cutover begins we can look at existing kv metrics for the total number of ranges in the cluster/tenant.

Jira issue: CRDB-24172

Epic CRDB-18752
@lidorcarmel lidorcarmel added the C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) label Feb 4, 2023
@lidorcarmel lidorcarmel self-assigned this Feb 4, 2023
@blathers-crl
Copy link

blathers-crl bot commented Feb 4, 2023

cc @cockroachdb/disaster-recovery

@lidorcarmel lidorcarmel mentioned this issue Feb 4, 2023
Merged
lidorcarmel added a commit to lidorcarmel/cockroach that referenced this issue Feb 6, 2023
@lidorcarmel
streamingest: add a metric for replication cutover progress
1e6af1e 
We already have the progress info in the job as the percentage of ranges
that were reverted. This commit adds the number of ranges that are left
to be reverted as a metric.

Epic: CRDB-18752

Fixes: cockroachdb#96536

Release note: None
craig bot pushed a commit that referenced this issue Feb 7, 2023
@lidorcarmel @RaduBerinde @pav-kv
Merge #96537 #96701 #96711
8022f2a 
96537: streamingest: add a metric for replication cutover progress r=lidorcarmel a=lidorcarmel

We already have the progress info in the job as the percentage of ranges that were reverted. This commit adds the number of ranges that are left to be reverted as a metric.

Epic: CRDB-18752

Fixes: #96536

Release note: None

96701: clusterversion: remove TODOPreV22_1 r=RaduBerinde a=RaduBerinde

This change removes this constant and the obsolete code that uses it.

Release note: None
Epic: None

96711: kvstorage: move uninit replica creation to kvstorage r=tbg a=pavelkalinnikov

This commit factors out the code that creates an uninitialized replica in
storage, into the kvstorage package.

Part of #93898

Co-authored-by: Lidor Carmel <[email protected]>
Co-authored-by: Radu Berinde <[email protected]>
Co-authored-by: Pavel Kalinnikov <[email protected]>
@craig craig bot closed this as completed in 45faeeb Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lidorcarmel lidorcarmel

Labels
A-disaster-recovery C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-disaster-recovery
Projects
No open projects
Disaster Recovery Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

streamingest: add a metric for replication cutover progress lidorcarmel/cockroach
1 participant
@lidorcarmel