schemachanger: improve state management #96117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
This commit came about because working on #95631 made me uneasy about whether it's legal for the builder to overwrite or elide existing targets. Also I wasn't quite convinced that the |
postamar
force-pushed
the
add-initial-to-current-state
branch
from
a594919 to
38fdba3
Compare
postamar
force-pushed
the
add-initial-to-current-state
branch
from
38fdba3 to
2ab2ab8
Compare
|
Thanks for the review! bors r+ |
This commit endows the scpb.CurrentState with the set of element statuses which are in force at the beginning of the statement transaction. These are then used when planning the pre-commit reset stage. This commit also rewrites the target-setting logic in the scbuild package in a more explicit manner with extra commentary. This commit does not change any functional behavior in production. Informs cockroachdb#88294. Release note: None
postamar
force-pushed
the
add-initial-to-current-state
branch
from
2ab2ab8 to
1266859
Compare
|
bors r+ |
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit endows the scpb.CurrentState with the set of element statuses which are in force at the beginning of the statement transaction. These are then used when planning the pre-commit reset stage.
This commit also rewrites the target-setting logic in the scbuild package in a more explicit manner with extra commentary.
This commit does not change any functional behavior in production.
Informs #88294.
Release note: None