Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-22.2: changefeedccl: fix deadlock in mocksyncproducer #95070

Merged
merged 1 commit into from
Jan 11, 2023
Merged

release-22.2: changefeedccl: fix deadlock in mocksyncproducer #95070

merged 1 commit into from
Jan 11, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Jan 11, 2023 •
edited by samiskin
Loading

Backport 1/1 commits from #91619 on behalf of @samiskin.

/cc @cockroachdb/release

Resolves #92722

Resolves #89028

TestChangefeedKafkaMessageTooLarge would flake sometimes with goroutines blocked on sending into the mocksyncproducer feedCh and would result in a "Slow on quiesce" error. This is likely due to the jobFeed shutting down which also shuts down the consumer of feedCh.

Release note: None

Release justification: Testing only change

@samiskin
changefeedccl: fix deadlock in mocksyncproducer
4808c4d 
TestChangefeedKafkaMessageTooLarge would flake sometimes with goroutines
blocked on sending into the mocksyncproducer feedCh and would result in
a "Slow on quiesce" error. This is likely due to the jobFeed shutting
down and therefore no longer reading from the feedCh.

Release note: None
@blathers-crl blathers-crl bot requested a review from a team as a code owner January 11, 2023 15:56
@blathers-crl blathers-crl bot requested review from shermanCRL and removed request for a team January 11, 2023 15:56
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.2-91619 branch from c8bffcc to 4808c4d Compare January 11, 2023 15:56
@blathers-crl
Copy link
Author

blathers-crl bot commented Jan 11, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot requested a review from miretskiy January 11, 2023 15:56
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Jan 11, 2023
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@samiskin samiskin merged commit 4c573eb into release-22.2 Jan 11, 2023
@samiskin samiskin deleted the blathers/backport-release-22.2-91619 branch January 11, 2023 17:55
@samiskin samiskin mentioned this pull request Jan 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samiskin samiskin samiskin approved these changes

@shermanCRL shermanCRL Awaiting requested review from shermanCRL shermanCRL is a code owner automatically assigned from cockroachdb/cdc-prs

@miretskiy miretskiy Awaiting requested review from miretskiy

Assignees

@samiskin samiskin

Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cockroach-teamcity @samiskin