changefeedccl: fix deadlock in mocksyncproducer #91619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TestChangefeedKafkaMessageTooLarge would flake sometimes with goroutines blocked on sending into the mocksyncproducer feedCh and would result in a "Slow on quiesce" error. This is likely due to the jobFeed shutting down and therefore no longer reading from the feedCh. Release note: None
|
This change is |
miretskiy
approved these changes
Nov 9, 2022
|
Do we have an issue on the flaky test? Maybe create one and reference from here? |
|
We had one in the past that I marked resolved since it didn't fail for a while, referencing that same issue seems to make the linter happy. |
|
bors r+ |
|
Build succeeded: |
|
blathers backport 22.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #89028
TestChangefeedKafkaMessageTooLarge would flake sometimes with goroutines blocked on sending into the mocksyncproducer feedCh and would result in a "Slow on quiesce" error. This is likely due to the jobFeed shutting down which also shuts down the consumer of feedCh.
Release note: None