Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.2.0: sql: add implicit_txn column to insights execution #90872

Merged
merged 1 commit into from
Oct 28, 2022

Conversation

maryliag
Copy link
Contributor

@maryliag maryliag commented Oct 28, 2022

Backport 1/1 commits from #90100.

/cc @cockroachdb/release


This commit adds a new column implicit_txn (boolean) to:

  • crdb_internal.cluster_execution_insights
  • crdb_internal.node_execution_insights

Part Of #87750

Release note (sql change): Adds a new column implicit_txn (boolean) to crdb_internal.cluster_execution_insights and crdb_internal.node_execution_insights


Release justification: changes required so CC UI won't break

This commit adds a new column `implicit_txn` (boolean) to:
- `crdb_internal.cluster_execution_insights`
- `crdb_internal.node_execution_insights`

Part Of cockroachdb#87750

Release note (sql change): Adds a new column `implicit_txn`
(boolean) to `crdb_internal.cluster_execution_insights` and
`crdb_internal.node_execution_insights`
@maryliag maryliag requested review from a team October 28, 2022 20:16
@blathers-crl
Copy link

blathers-crl bot commented Oct 28, 2022

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@maryliag maryliag removed the request for review from a team October 28, 2022 22:07
@maryliag maryliag merged commit 22d02d7 into cockroachdb:release-22.2.0 Oct 28, 2022
@maryliag maryliag deleted the backport22.2.0-90100 branch October 28, 2022 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants