Acceptance testing 22.2 - No correlation from Statement (and Transaction) execution insight details to Fingerprint details #87750
Assignees
Labels
C-enhancement
Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Comments
kevin-v-ngo
added
the
C-enhancement
kevin-v-ngo
changed the title
|
This requires the transaction type as well (implicit and explicit) |
maryliag
added a commit
to maryliag/cockroach
that referenced
this issue
Oct 17, 2022
This commit adds a new column `implicit_txn` (boolean) to: - `crdb_internal.cluster_execution_insights` - `crdb_internal.node_execution_insights` Part Of cockroachdb#87750 Release note (sql change): Adds a new column `implicit_txn` (boolean) to `crdb_internal.cluster_execution_insights` and `crdb_internal.node_execution_insights`
maryliag
added a commit
to maryliag/cockroach
that referenced
this issue
Oct 18, 2022
This commit adds a new column `implicit_txn` (boolean) to: - `crdb_internal.cluster_execution_insights` - `crdb_internal.node_execution_insights` Part Of cockroachdb#87750 Release note (sql change): Adds a new column `implicit_txn` (boolean) to `crdb_internal.cluster_execution_insights` and `crdb_internal.node_execution_insights`
maryliag
added a commit
to maryliag/cockroach
that referenced
this issue
Oct 18, 2022
This commit adds a new column `implicit_txn` (boolean) to: - `crdb_internal.cluster_execution_insights` - `crdb_internal.node_execution_insights` Part Of cockroachdb#87750 Release note (sql change): Adds a new column `implicit_txn` (boolean) to `crdb_internal.cluster_execution_insights` and `crdb_internal.node_execution_insights`
craig bot
pushed a commit
that referenced
this issue
Oct 18, 2022
90100: sql: add implicit_txn column to insights execution r=maryliag a=maryliag This commit adds a new column `implicit_txn` (boolean) to: - `crdb_internal.cluster_execution_insights` - `crdb_internal.node_execution_insights` Part Of #87750 Release note (sql change): Adds a new column `implicit_txn` (boolean) to `crdb_internal.cluster_execution_insights` and `crdb_internal.node_execution_insights` Co-authored-by: maryliag <[email protected]>
maryliag
added a commit
to maryliag/cockroach
that referenced
this issue
Oct 20, 2022
Now from the Insights page, clicking on the statement or fingerprint ids, it will bring you to their respective details page. This commit also filter out transaction insights that didn't have their value set yet (meaning they're still 0). Finally, this commit fixes the start/end values being passed to the combined statement endpoint, to the correct rounded values, aligning what we say on the UI. Fixes cockroachdb#87750 Release note (ui change): The fingerprint id values for statement and transactions on the insights pages are links that open the respective details page on the time period of the execution of that statement/transaction. Release note (bug fix): Sendind the proper start/end values to the endpoint used on SQL Activity page, now returning the full hour as described on the UI.
maryliag
added a commit
to maryliag/cockroach
that referenced
this issue
Oct 21, 2022
Now from the Insights page, clicking on the statement or fingerprint ids, it will bring you to their respective details page. This commit also filter out transaction insights that didn't have their value set yet (meaning they're still 0). Finally, this commit fixes the start/end values being passed to the combined statement endpoint, to the correct rounded values, aligning what we say on the UI. Fixes cockroachdb#87750 Release note (ui change): The fingerprint id values for statement and transactions on the insights pages are links that open the respective details page on the time period of the execution of that statement/transaction. Release note (bug fix): Sendind the proper start/end values to the endpoint used on SQL Activity page, now returning the full hour as described on the UI.
maryliag
added a commit
to maryliag/cockroach
that referenced
this issue
Oct 21, 2022
Now from the Insights page, clicking on the statement or fingerprint ids, it will bring you to their respective details page. This commit also filter out transaction insights that didn't have their value set yet (meaning they're still 0). Finally, this commit fixes the start/end values being passed to the combined statement endpoint, to the correct rounded values, aligning what we say on the UI. Fixes cockroachdb#87750 Release note (ui change): The fingerprint id values for statement and transactions on the insights pages are links that open the respective details page on the time period of the execution of that statement/transaction. Release note (bug fix): Sendind the proper start/end values to the endpoint used on SQL Activity page, now returning the full hour as described on the UI.
craig bot
pushed a commit
that referenced
this issue
Oct 21, 2022
90210: server: limit concurrency of table stats requests r=ajwerner a=ajwerner These requests can be very expensive, especially if there are lots of ranges. Furthermore, the number of requests to be sent tends to scale with the number of tables, just like the range count. This unbounded concurrency was a recipe for trouble. Informs #90196. Release note (ui change): Requests to fetch table and database statistics now have limited concurrency. This may make loading the database page slower, but in return should result in making those pages less disruptive. 90403: ui: link insights to fingerprint details r=maryliag a=maryliag Now from the Insights page, clicking on the statement or fingerprint ids, it will bring you to their respective details page. This commit also filter out transaction insights that didn't have their value set yet (meaning they're still 0). Finally, this commit fixes the start/end values being passed to the combined statement endpoint, to the correct rounded values, aligning what we say on the UI. Fixes #87750 https://www.loom.com/share/d9d6de0c78af4496b538a905732c745b Note to reviewers: the bug displayed on the video will be addressed on #90397 Release note (ui change): The fingerprint id values for statement and transactions on the insights pages are links that open the respective details page on the time period of the execution of that statement/transaction. Release note (bug fix): Sendind the proper start/end values to the endpoint used on SQL Activity page, now returning the full hour as described on the UI. Co-authored-by: Andrew Werner <[email protected]> Co-authored-by: maryliag <[email protected]>
maryliag
added a commit
to maryliag/cockroach
that referenced
this issue
Oct 25, 2022
This commit adds a new column `implicit_txn` (boolean) to: - `crdb_internal.cluster_execution_insights` - `crdb_internal.node_execution_insights` Part Of cockroachdb#87750 Release note (sql change): Adds a new column `implicit_txn` (boolean) to `crdb_internal.cluster_execution_insights` and `crdb_internal.node_execution_insights`
maryliag
added a commit
to maryliag/cockroach
that referenced
this issue
Oct 25, 2022
Now from the Insights page, clicking on the statement or fingerprint ids, it will bring you to their respective details page. This commit also filter out transaction insights that didn't have their value set yet (meaning they're still 0). Finally, this commit fixes the start/end values being passed to the combined statement endpoint, to the correct rounded values, aligning what we say on the UI. Fixes cockroachdb#87750 Release note (ui change): The fingerprint id values for statement and transactions on the insights pages are links that open the respective details page on the time period of the execution of that statement/transaction. Release note (bug fix): Sendind the proper start/end values to the endpoint used on SQL Activity page, now returning the full hour as described on the UI.
ericharmeling
pushed a commit
to ericharmeling/cockroach
that referenced
this issue
Oct 28, 2022
Now from the Insights page, clicking on the statement or fingerprint ids, it will bring you to their respective details page. This commit also filter out transaction insights that didn't have their value set yet (meaning they're still 0). Finally, this commit fixes the start/end values being passed to the combined statement endpoint, to the correct rounded values, aligning what we say on the UI. Fixes cockroachdb#87750 Release note (ui change): The fingerprint id values for statement and transactions on the insights pages are links that open the respective details page on the time period of the execution of that statement/transaction. Release note (bug fix): Sendind the proper start/end values to the endpoint used on SQL Activity page, now returning the full hour as described on the UI.
ericharmeling
pushed a commit
to ericharmeling/cockroach
that referenced
this issue
Oct 28, 2022
This commit adds a new column `implicit_txn` (boolean) to: - `crdb_internal.cluster_execution_insights` - `crdb_internal.node_execution_insights` Part Of cockroachdb#87750 Release note (sql change): Adds a new column `implicit_txn` (boolean) to `crdb_internal.cluster_execution_insights` and `crdb_internal.node_execution_insights`
maryliag
added a commit
to maryliag/cockroach
that referenced
this issue
Oct 28, 2022
This commit adds a new column `implicit_txn` (boolean) to: - `crdb_internal.cluster_execution_insights` - `crdb_internal.node_execution_insights` Part Of cockroachdb#87750 Release note (sql change): Adds a new column `implicit_txn` (boolean) to `crdb_internal.cluster_execution_insights` and `crdb_internal.node_execution_insights`
This was referenced Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We should provide a link from the statement and transaction execution insight details page to fingerprint detail. Time range should be based on the insight execution time.
Jira issue: CRDB-19512
Epic CRDB-20388
The text was updated successfully, but these errors were encountered: