backupccl: update backupAndRestore test helper #90621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
msbutler
force-pushed
the
butler-backuprestore-test
branch
from
b282ad0 to
6c28fed
Compare
Informs cockroachdb#90620 This patch updates the backupAndRestore test helper to: - use the new backup/restore syntax - removes an unecessary test cluster spin up - simplifies a bunch of logic around external storage format - adds an incremental backup With this patch, our TestCloudBackupRestore* tests will now exercise the required external storage calls (e.g. listing) for the new backup directory structure. Release note: none
msbutler
force-pushed
the
butler-backuprestore-test
branch
from
6c28fed to
f8d42f1
Compare
msbutler
requested review from
benbardin,
stevendanna and
adityamaru
and removed request for
a team and
benbardin
adityamaru
approved these changes
Nov 1, 2022
|
passed with flying colors! Mysteriously, TestPutAWSKMSEndpoint and TestPutS3Endpoint are currently ignored here, and on master. I'll dig a bit, but merge this PR. |
|
bors r=adityamaru |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Informs #90620
This patch updates the backupAndRestore test helper to:
With this patch, our TestCloudBackupRestore* tests will now exercise the
required external storage calls (e.g. listing) for the new backup directory
structure.
Release note: None