Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backupccl: remove old backup/restore syntax from test suite #90620

Open
msbutler opened this issue Oct 25, 2022 · 2 comments
Open

backupccl: remove old backup/restore syntax from test suite #90620

msbutler opened this issue Oct 25, 2022 · 2 comments
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-disaster-recovery

Comments

@msbutler
Copy link
Collaborator

msbutler commented Oct 25, 2022 •
edited by cockroach-jira-scripts
Loading

Many tests invoke the old backup/restore syntax. These tests need to be updated to use the new syntax before we delete old syntax logic from the codebase.

Jira issue: CRDB-20863
@msbutler msbutler added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-disaster-recovery labels Oct 25, 2022
@blathers-crl
Copy link

blathers-crl bot commented Oct 25, 2022

cc @cockroachdb/disaster-recovery

@msbutler msbutler mentioned this issue Oct 25, 2022
Merged
@msbutler msbutler removed their assignment Oct 25, 2022
msbutler added a commit to msbutler/cockroach that referenced this issue Oct 27, 2022
@msbutler
backupccl: update backupAndRestore test helper
f8d42f1 
Informs cockroachdb#90620

This patch updates the backupAndRestore test helper to:
- use the new backup/restore syntax
- removes an unecessary test cluster spin up
- simplifies a bunch of logic around external storage format
- adds an incremental backup

With this patch, our TestCloudBackupRestore* tests will now exercise the
required external storage calls (e.g. listing) for the new backup directory
structure.

Release note: none
craig bot pushed a commit that referenced this issue Nov 1, 2022
@msbutler
Merge #90621
82fdf05 
90621: backupccl: update backupAndRestore test helper r=adityamaru a=msbutler

Informs #90620

This patch updates the backupAndRestore test helper to:
- use the new backup/restore syntax
- removes an unecessary test cluster spin up
- simplifies a bunch of logic around external storage format
- adds an incremental backup

With this patch, our TestCloudBackupRestore* tests will now exercise the
required external storage calls (e.g. listing) for the new backup directory
structure.

Release note: None

Co-authored-by: Michael Butler <[email protected]>
@github-actions GitHub Actions
Copy link

We have marked this issue as stale because it has been inactive for
18 months. If this issue is still relevant, removing the stale label
or adding a comment will keep it active. Otherwise, we'll close it in
10 days to keep the issue queue tidy. Thank you for your contribution
to CockroachDB!

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 29, 2024
@yuzefovich yuzefovich reopened this May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-disaster-recovery
Projects
No open projects
Disaster Recovery Backlog
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yuzefovich @msbutler