-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cloud: add read and write metrics #89584
Conversation
3197ce2
to
120206b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we concerned that the retry count is potentially not going to reflect retries in the implementation of some clients and/or at a higher layer either? A misleading metric might be worse than no metric eg if someone looks at it, sees it is flat and dismisses retries even if they're happening inside foo-sdk or library?
Yeah that's a good point and one that crossed my mind when I was plumbing counter increments into all the retry loops. We could try to be diligent about having all clients read and write paths that we retry in Alternatively, we could breakdown the retries into |
120206b
to
22f50d9
Compare
199cb4f
to
1b8933b
Compare
1b8933b
to
38261da
Compare
38261da
to
79b23e0
Compare
TFTR! bors r=dt |
Merge conflict. |
79b23e0
to
e95eb44
Compare
This change adds cloud.read_bytes and cloud.write_bytes metrics. These are updated on all read/write operations to external storage endpoints. These metrics while shared by all external storage interactions will provide an immediate signal into whether we're seeing an abnormal rate of reads and writes errors during support investigations. Fixes: cockroachdb#89242 Release note: None
e95eb44
to
17a5159
Compare
bors r=dt,stevendanna |
bors retry |
bors r- |
Canceled. |
bors r+ |
Build succeeded: |
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from 17a5159 to blathers/backport-release-22.2-89584: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 22.2.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
This change adds cloud.read_bytes and cloud.write_bytes metrics.
These are updated on all read/write operations to external storage endpoints.
These metrics while shared by all external storage interactions
will provide an immediate signal into whether we're seeing an
abnormal rate of reads and writes errors during support investigations.
Fixes: #89242
Release note: None