Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roachtest: copy/bank/rows=1000000,nodes=9,txn=false failed #91340

Closed
cockroach-teamcity opened this issue Nov 5, 2022 · 4 comments · Fixed by #91427
Closed

roachtest: copy/bank/rows=1000000,nodes=9,txn=false failed #91340

cockroach-teamcity opened this issue Nov 5, 2022 · 4 comments · Fixed by #91427
Labels
A-testing Testing tools and infrastructure branch-master Failures and bugs on the master branch. C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-kv KV Team
Milestone
23.1

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Nov 5, 2022 •
edited by cockroach-jira-scripts
Loading

roachtest.copy/bank/rows=1000000,nodes=9,txn=false failed with artifacts on master @ 2c0129ce2507e708382cda830d1e47817a299c2e:

test artifacts and logs in: /artifacts/copy/bank/rows=1000000_nodes=9_txn=false/run_1
(test_impl.go:291).Fatal: output in run_082152.121817741_n1_workload_fixtures_load_bank: ./workload fixtures load bank --rows=1000000 --payload-bytes=100 {pgurl:1} returned: COMMAND_PROBLEM: exit status 1
(test_impl.go:291).Fatal: monitor failure: monitor task failed: t.Fatal() was called

Parameters: ROACHTEST_cloud=gce , ROACHTEST_cpu=4 , ROACHTEST_encrypted=false , ROACHTEST_fs=ext4 , ROACHTEST_localSSD=true , ROACHTEST_ssd=0

Help

See: roachtest README

See: How To Investigate (internal)

/cc @cockroachdb/kv-triage

This test on roachdash | Improve this report!

Jira issue: CRDB-21212
@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. labels Nov 5, 2022
@cockroach-teamcity cockroach-teamcity added this to the 23.1 milestone Nov 5, 2022
@blathers-crl blathers-crl bot added the T-kv KV Team label Nov 5, 2022
@cockroach-teamcity
Copy link
Member Author

roachtest.copy/bank/rows=1000000,nodes=9,txn=false failed with artifacts on master @ c9094fa1a1ef8d44a2d5299d1d7380b34a06241b:

test artifacts and logs in: /artifacts/copy/bank/rows=1000000_nodes=9_txn=false/run_1
(test_impl.go:291).Fatal: output in run_090819.394560927_n1_workload_fixtures_load_bank: ./workload fixtures load bank --rows=1000000 --payload-bytes=100 {pgurl:1} returned: COMMAND_PROBLEM: exit status 1
(test_impl.go:291).Fatal: monitor failure: monitor task failed: t.Fatal() was called

Parameters: ROACHTEST_cloud=gce , ROACHTEST_cpu=4 , ROACHTEST_encrypted=false , ROACHTEST_fs=ext4 , ROACHTEST_localSSD=true , ROACHTEST_ssd=0

Help

See: roachtest README

See: How To Investigate (internal)

This test on roachdash | Improve this report!

@nvanbenschoten
Copy link
Member

Both tests failed with the error:

Error: failed to create google cloud client (You may need to setup the GCS application default credentials: 'gcloud auth application-default login --project=cockroach-shared'): invalid metrics type: <nil>

@adityamaru do you think this is related to #89584?

@cockroach-teamcity
Copy link
Member Author

roachtest.copy/bank/rows=1000000,nodes=9,txn=false failed with artifacts on master @ 4c828ca5df8ea70b92ba58c6cb4868303cee1262:

test artifacts and logs in: /artifacts/copy/bank/rows=1000000_nodes=9_txn=false/run_1
(test_impl.go:291).Fatal: output in run_091425.922925596_n1_workload_fixtures_load_bank: ./workload fixtures load bank --rows=1000000 --payload-bytes=100 {pgurl:1} returned: COMMAND_PROBLEM: exit status 1
(test_impl.go:291).Fatal: monitor failure: monitor task failed: t.Fatal() was called

Parameters: ROACHTEST_cloud=gce , ROACHTEST_cpu=4 , ROACHTEST_encrypted=false , ROACHTEST_fs=ext4 , ROACHTEST_localSSD=true , ROACHTEST_ssd=0

Help

See: roachtest README

See: How To Investigate (internal)

This test on roachdash | Improve this report!

@adityamaru adityamaru mentioned this issue Nov 7, 2022
Merged
@cockroach-teamcity
Copy link
Member Author

roachtest.copy/bank/rows=1000000,nodes=9,txn=false failed with artifacts on master @ ff8f7eda167887e1f11bbcd9029aa4cc2d28085e:

test artifacts and logs in: /artifacts/copy/bank/rows=1000000_nodes=9_txn=false/run_1
(test_impl.go:291).Fatal: output in run_091838.168280075_n1_workload_fixtures_load_bank: ./workload fixtures load bank --rows=1000000 --payload-bytes=100 {pgurl:1} returned: COMMAND_PROBLEM: exit status 1
(test_impl.go:291).Fatal: monitor failure: monitor task failed: t.Fatal() was called

Parameters: ROACHTEST_cloud=gce , ROACHTEST_cpu=4 , ROACHTEST_encrypted=false , ROACHTEST_fs=ext4 , ROACHTEST_localSSD=true , ROACHTEST_ssd=0

Help

See: roachtest README

See: How To Investigate (internal)

This test on roachdash | Improve this report!

craig bot pushed a commit that referenced this issue Nov 8, 2022
@ecwall @adityamaru
Merge #90993 #91290 #91391 #91427
5cc48be 
90993: ttl: Remove 22.1 non-DistSQL compatibility in 23.1 r=rafiss a=ecwall

fixes #87060

This removes compatibility between mixed 22.1 and 22.2 clusters that uses non-DistSQL behavior.

Release note: None

91290: ui: Changed css styling on metrics graph tooltips to prevent collapse r=nathanstilwell a=nathanstilwell

Currently the time series graphs tooltip overlay has css properties that allow the content to collapse when it reaches the boundary of the graph. This can make the information in the tooltip unreadable in certain cases.

<img width="676" alt="Screen Shot 2022-11-04 at 11 35 45 AM" src="https://user-images.githubusercontent.com/397448/200025745-74fdf4e4-5583-4d61-a692-b5eee2b850e8.png">

By changing the style controlling the tooltip width, this collapse can be prevented, maintaining the readability of the content.

<img width="778" alt="Screen Shot 2022-11-04 at 11 35 22 AM" src="https://user-images.githubusercontent.com/397448/200025794-4c66d3b1-a6f1-468f-b167-99121ef1df34.png">

fixes #86778 

91391: multitenant: move UNSPLIT AT tenant check from SQL to KV layer r=knz a=ecwall

fixes #91390

Move the UNSPLIT AT tenant check from the SQL to KV layer to prepare for tenant permissions work. This check will eventually be replaced by a tenant permissions lookup to determine if the tenant can perform the requested KV operation (AdminUnsplit in this case). `Codec.ForSystemTenant()` checks still exist in the SQL and will be handled in separate PRs.

Release note: None

91427: workloadccl: fix incorrect metrics during ExternalStroage init r=adityamaru a=adityamaru

Fixes: #91340

Release note: None

Co-authored-by: Evan Wall <[email protected]>
Co-authored-by: Nathan Stilwell <[email protected]>
Co-authored-by: adityamaru <[email protected]>
@craig craig bot closed this as completed in 13a61b6 Nov 8, 2022
@lunevalex lunevalex added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-testing Testing tools and infrastructure labels Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-testing Testing tools and infrastructure branch-master Failures and bugs on the master branch. C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-kv KV Team
Projects
None yet
Milestone
23.1
Development

Successfully merging a pull request may close this issue.

workloadccl: fix incorrect metrics during ExternalStroage init adityamaru/cockroach
3 participants
@nvanbenschoten @cockroach-teamcity @lunevalex