Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-22.2: scbuildstmt: fallback if adding a virtual column with NOT NULL #87545

Merged
merged 1 commit into from
Sep 8, 2022
Merged

release-22.2: scbuildstmt: fallback if adding a virtual column with NOT NULL #87545

merged 1 commit into from
Sep 8, 2022

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Sep 7, 2022

Backport 1/1 commits from #87459 on behalf of @Xiang-Gu.

/cc @cockroachdb/release

We found a regression in the new schema changer for the following stmt: ALTER TABLE t ADD COLUMN j INT AS (NULL::INT) VIRTUAL NOT NULL; incorrectly succeeded. This PR made ADD COLUMN fall back if the to-be-added column is a virtual column with NOT NULL constraint.

Surprisingly, we actually have logic tests in place for this case but it has incorrect expected output so we also changed the exsiting tests.

Fix: #87457

Release justification: bug fix for GA blocker.

Release note: None

Release justification:

@Xiang-Gu
scbuildstmt: fallback if adding a virtual column with NOT NULL
c5d4a25 
We found a regression in the new schema changer for the following stmt:
`ALTER TABLE t ADD COLUMN j INT AS (NULL::INT) VIRTUAL NOT NULL;`
incorrectly succeeded. This PR made `ADD COLUMN` fall back if the
to-be-added column is a virtual column with NOT NULL constraint.

Surprisingly, we actually have logic tests in place for this case but
it has incorrect expected output so we also changed the exsiting tests.

Release justification: bug fix for GA blocker.

Release note: None
@blathers-crl blathers-crl bot requested a review from a team September 7, 2022 23:03
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.2-87459 branch from 6953808 to c5d4a25 Compare September 7, 2022 23:04
@blathers-crl blathers-crl bot requested a review from ajwerner September 7, 2022 23:04
@blathers-crl blathers-crl bot added the blathers-backport This is a backport that Blathers created automatically. label Sep 7, 2022
@blathers-crl
Copy link
Author

blathers-crl bot commented Sep 7, 2022 •
edited by ajwerner
Loading

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot added the O-robot Originated from a bot. label Sep 7, 2022
@cockroach-teamcity
Copy link
Member

This change is Reviewable

ajwerner
ajwerner approved these changes Sep 8, 2022
View reviewed changes
Copy link
Contributor

@ajwerner ajwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @Xiang-Gu)

@Xiang-Gu Xiang-Gu merged commit f37fdac into release-22.2 Sep 8, 2022
@Xiang-Gu Xiang-Gu deleted the blathers/backport-release-22.2-87459 branch September 8, 2022 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajwerner ajwerner ajwerner approved these changes

Assignees

@Xiang-Gu Xiang-Gu

Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cockroach-teamcity @ajwerner @Xiang-Gu