scbuildstmt: fallback if adding a virtual column with NOT NULL #87459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We found a regression in the new schema changer for the following stmt: `ALTER TABLE t ADD COLUMN j INT AS (NULL::INT) VIRTUAL NOT NULL;` incorrectly succeeded. This PR made `ADD COLUMN` fall back if the to-be-added column is a virtual column with NOT NULL constraint. Surprisingly, we actually have logic tests in place for this case but it has incorrect expected output so we also changed the exsiting tests. Release justification: bug fix for GA blocker. Release note: None
|
This change is |
ajwerner
approved these changes
Sep 7, 2022
There was a problem hiding this comment.
Relates to #81690.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @Xiang-Gu)
|
TFTR! bors r+ |
|
Build succeeded: |
Xiang-Gu
deleted the
fallback_add_virtual_column_with_not_null_constraint
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found a regression in the new schema changer for the following stmt:
ALTER TABLE t ADD COLUMN j INT AS (NULL::INT) VIRTUAL NOT NULL;incorrectly succeeded. This PR madeADD COLUMNfall back if the to-be-added column is a virtual column with NOT NULL constraint.Surprisingly, we actually have logic tests in place for this case but it has incorrect expected output so we also changed the exsiting tests.
Fix: #87457
Release justification: bug fix for GA blocker.
Release note: None