Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-21.2: sql: allow user to see pg_catalog data for current database #83359

Merged
merged 1 commit into from
Jun 26, 2022

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Jun 24, 2022

Backport 1/1 commits from #83339 on behalf of @rafiss.

/cc @cockroachdb/release


Release note (bug fix): Previously a user could be connected to a
database, but be unable to see the metadata for that database in
pg_catalog if the user did not have privileges (e.g. CONNECT) for the
database. Now, a user can always see the pg_catalog metadata for
the current database they are connected to.

This is needed because CockroachDB currently does not require the
CONNECT privilege to connect to a database (see
#59875).


Release justification: bug fix with low risk

@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-21.2-83339 branch from a308ead to 5ad9f6b Compare June 24, 2022 22:40
@blathers-crl
Copy link
Author

blathers-crl bot commented Jun 24, 2022

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot requested a review from RichardJCai June 24, 2022 22:40
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Jun 24, 2022
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rafiss rafiss force-pushed the blathers/backport-release-21.2-83339 branch from 5ad9f6b to f9ad698 Compare June 25, 2022 06:16
Release note (bug fix): Previously a user could be connected to a
database, but be unable to see the metadata for that database in
pg_catalog if the user did not have privileges (e.g. CONNECT) for the
database. Now, a user can always see the pg_catalog metadata for
the current database they are connected to.

This is needed because CockroachDB currently does not require the
CONNECT privilege to connect to a database (see
#59875).
@rafiss rafiss force-pushed the blathers/backport-release-21.2-83339 branch from f9ad698 to d51d065 Compare June 25, 2022 15:05
@rafiss rafiss merged commit 7ec705a into release-21.2 Jun 26, 2022
@rafiss rafiss deleted the blathers/backport-release-21.2-83339 branch June 26, 2022 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants