sql: allow user to see pg_catalog data for current database #83339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
RichardJCai
approved these changes
Jun 24, 2022
Release note (bug fix): Previously a user could be connected to a database, but be unable to see the metadata for that database in pg_catalog if the user did not have privileges (e.g. CONNECT) for the database. Now, a user can always see the pg_catalog metadata for the current database they are connected to. This is needed because CockroachDB currently does not require the CONNECT privilege to connect to a database (see cockroachdb#59875).
rafiss
force-pushed
the
privs-for-vtables
branch
from
a0428f7 to
261b898
Compare
|
looks like a CI flake. tftr! bors r+ |
|
Build succeeded: |
This was referenced Jun 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release note (bug fix): Previously a user could be connected to a
database, but be unable to see the metadata for that database in
pg_catalog if the user did not have privileges (e.g. CONNECT) for the
database. Now, a user can always see the pg_catalog metadata for
the current database they are connected to.
This is needed because CockroachDB currently does not require the
CONNECT privilege to connect to a database (see
#59875).