ui: add period label to SQL Activity pages #83103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the period label with information about the period to which we're showing information from. The label is added to Statement, Statement Details, Transaction and Transaction Details pages. Partially addresses cockroachdb#82914 Fixes cockroachdb#74523 This commit also removed the tab Exec Stats from the Statement Details page. Fixes cockroachdb#74526 Release note (ui change): Add period label to pages Statement, Statement Details and Transaction, with information about the period to which we're showing information from. Removal of exec stats tab under Statement Details page.
|
This change is |
xinhaoz
approved these changes
Jun 23, 2022
There was a problem hiding this comment.
Reviewed 3 of 9 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @xinhaoz)
|
bors r+ |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build succeeded: |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from b68baf5 to blathers/backport-release-22.1-83103: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 22.1.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the period label with information
about the period to which we're showing information from.
The label is added to Statement, Statement Details,
Transaction and Transaction Details pages.
Partially addresses #82914
Fixes #74523
Statement page no filter
Statement Page with filter
Statement Details Overview Tab
Statement Details Explain Tab
Transaction page no filter
Transaction page with filter
Transaction Details
This commit also removed the tab Exec Stats from the
Statement Details page.
Fixes #74526
Release note (ui change): Add period label to pages Statement, Statement Details,
Transaction and Transaction Details, with information about the
period to which we're showing information from. Removal of
Exec stats tab under Statement Details page.