Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor text and UI changes to Statements and Transactions pages #74526

Closed
jocrl opened this issue Jan 6, 2022 · 0 comments · Fixed by #83103
Closed

Minor text and UI changes to Statements and Transactions pages #74526

jocrl opened this issue Jan 6, 2022 · 0 comments · Fixed by #83103
Assignees
@maryliag
Labels
A-sql-console-general SQL Observability issues on the DB console spanning multiple areas. Includes Cockroach Cloud Console C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@jocrl
Copy link
Contributor

jocrl commented Jan 6, 2022 •
edited by cockroach-jira-scripts
Loading

  • change Statement Details page title
  • remove Execution Stats tab
  • change no data error message

Figma mockups: https://www.figma.com/file/xdmwvnFQd6KkO9RJ0XLDH0/22.1_SQL-obsrv_query-performance?node-id=3488%3A10430
Epic: CRDB-6564

Jira issue: CRDB-12139
@jocrl jocrl added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-observability A-sql-console-general SQL Observability issues on the DB console spanning multiple areas. Includes Cockroach Cloud Console labels Jan 6, 2022
@jocrl jocrl self-assigned this Jan 6, 2022
@maryliag maryliag self-assigned this Jun 16, 2022
@maryliag maryliag mentioned this issue Jun 20, 2022
Merged
craig bot pushed a commit that referenced this issue Jun 23, 2022
@maryliag
Merge #83103
9cb9bc5 
83103: ui: add period label to SQL Activity pages r=maryliag a=maryliag

This commit adds the period label with information
about the period to which we're showing information from.
The label is added to Statement, Statement Details,
Transaction and Transaction Details pages.

Partially addresses #82914
Fixes #74523

Statement page no filter
<img width="851" alt="Screen Shot 2022-06-20 at 10 17 23 AM" src="https://user-images.githubusercontent.com/1017486/174626137-729a8351-a32d-46df-a884-a9aeb49a8ace.png">

Statement Page with filter
<img width="883" alt="Screen Shot 2022-06-20 at 10 17 07 AM" src="https://user-images.githubusercontent.com/1017486/174626135-e39be0d4-045c-49bc-b886-4337cb4baf21.png">

Statement Details Overview Tab
<img width="468" alt="Screen Shot 2022-06-20 at 10 18 24 AM" src="https://user-images.githubusercontent.com/1017486/174626138-2b5bae17-f64f-4ddd-a8eb-de0f92f53a3b.png">

Statement Details Explain Tab
<img width="463" alt="Screen Shot 2022-06-20 at 10 18 30 AM" src="https://user-images.githubusercontent.com/1017486/174626141-1e925490-667c-47e9-bc6e-b8227d189c1a.png">

Transaction page no filter
<img width="874" alt="Screen Shot 2022-06-20 at 10 21 24 AM" src="https://user-images.githubusercontent.com/1017486/174626144-10448c80-df40-4b85-bae5-19484fa97752.png">

Transaction page with filter
<img width="756" alt="Screen Shot 2022-06-20 at 10 21 38 AM" src="https://user-images.githubusercontent.com/1017486/174626146-16a0ad7b-7506-4447-8f5e-c29a0d9cde56.png">

Transaction Details
<img width="647" alt="Screen Shot 2022-06-20 at 10 36 51 AM" src="https://user-images.githubusercontent.com/1017486/174626147-de9619c6-b11e-42c7-90b3-57a5bed1f6f6.png">


This commit also removed the tab Exec Stats from the
Statement Details page.

Fixes #74526

Release note (ui change): Add period label to pages Statement, Statement Details, 
Transaction and Transaction Details, with information about the
period to which we're showing information from. Removal of
Exec stats tab under Statement Details page.

Co-authored-by: Marylia Gutierrez <[email protected]>
@craig craig bot closed this as completed in b68baf5 Jun 23, 2022
@maryliag maryliag mentioned this issue Jun 24, 2022
Merged
maryliag added a commit to maryliag/cockroach that referenced this issue Jun 24, 2022
@maryliag
ui: add period label to SQL Activity pages
c74f1db 
This commit adds the period label with information
about the period to which we're showing information from.
The label is added to Statement, Statement Details,
Transaction and Transaction Details pages.

Partially addresses cockroachdb#82914
Fixes cockroachdb#74523

This commit also removed the tab Exec Stats from the
Statement Details page.

Fixes cockroachdb#74526

Release note (ui change): Add period label to pages Statement,
Statement Details and Transaction, with information about the
period to which we're showing information from. Removal of
exec stats tab under Statement Details page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maryliag maryliag

Labels
A-sql-console-general SQL Observability issues on the DB console spanning multiple areas. Includes Cockroach Cloud Console C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ui: add period label to SQL Activity pages maryliag/cockroach
2 participants
@maryliag @jocrl