-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ccl/streamingccl/streamingest: skip flakey TestTenantStreaming #82837
Merged
craig
merged 1 commit into
cockroachdb:master
from
ajwerner:ajwerner/skip-TestTenantStreaming
Jun 14, 2022
Merged
ccl/streamingccl/streamingest: skip flakey TestTenantStreaming #82837
craig
merged 1 commit into
cockroachdb:master
from
ajwerner:ajwerner/skip-TestTenantStreaming
Jun 14, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevendanna
approved these changes
Jun 13, 2022
ajwerner
requested review from
a team and
msbutler
and removed request for
a team
June 13, 2022 18:28
bors r+ |
Build failed (retrying...): |
bors cancel |
Canceled. |
stevendanna
reviewed
Jun 13, 2022
@@ -80,6 +80,7 @@ func verifyIngestionStats(t *testing.T, streamID int64, cutoverTime time.Time, s | |||
func TestTenantStreaming(t *testing.T) { | |||
defer leaktest.AfterTest(t)() | |||
defer log.Scope(t).Close(t) | |||
skip.WithIsue(t, 82706) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm bad at code review.
Suggested change
skip.WithIsue(t, 82706) | |
skip.WithIssue(t, 82706) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mea culpa, fixed
Touches cockroachdb#82706. Release note: None
ajwerner
force-pushed
the
ajwerner/skip-TestTenantStreaming
branch
from
June 13, 2022 20:13
799692c
to
9c9d291
Compare
stevendanna
approved these changes
Jun 13, 2022
bors r+ |
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Touches #82706.
Release note: None