Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ccl/streamingccl/streamingest: skip flakey TestTenantStreaming #82837

Merged

Conversation

ajwerner
Copy link
Contributor

Touches #82706.

Release note: None

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@ajwerner ajwerner marked this pull request as ready for review June 13, 2022 18:28
@ajwerner ajwerner requested review from a team and msbutler and removed request for a team June 13, 2022 18:28
@ajwerner
Copy link
Contributor Author

bors r+

@craig
Copy link
Contributor

craig bot commented Jun 13, 2022

Build failed (retrying...):

@stevendanna
Copy link
Collaborator

bors cancel

@craig
Copy link
Contributor

craig bot commented Jun 13, 2022

Canceled.

@@ -80,6 +80,7 @@ func verifyIngestionStats(t *testing.T, streamID int64, cutoverTime time.Time, s
func TestTenantStreaming(t *testing.T) {
defer leaktest.AfterTest(t)()
defer log.Scope(t).Close(t)
skip.WithIsue(t, 82706)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm bad at code review.

Suggested change
skip.WithIsue(t, 82706)
skip.WithIssue(t, 82706)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mea culpa, fixed

@ajwerner ajwerner force-pushed the ajwerner/skip-TestTenantStreaming branch from 799692c to 9c9d291 Compare June 13, 2022 20:13
@ajwerner
Copy link
Contributor Author

bors r+

@craig
Copy link
Contributor

craig bot commented Jun 14, 2022

Build succeeded:

@craig craig bot merged commit 193442a into cockroachdb:master Jun 14, 2022
@shermanCRL shermanCRL added the A-tenant-streaming Including cluster streaming label Jul 29, 2022
@shermanCRL shermanCRL added this to the 22.2 milestone Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tenant-streaming Including cluster streaming
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants