-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ccl/streamingccl/streamingest: TestTenantStreaming failed #82706
Labels
branch-master
Failures and bugs on the master branch.
C-test-failure
Broken test (automatically or manually discovered).
O-robot
Originated from a bot.
skipped-test
T-disaster-recovery
Comments
cockroach-teamcity
added
branch-master
Failures and bugs on the master branch.
C-test-failure
Broken test (automatically or manually discovered).
O-robot
Originated from a bot.
labels
Jun 10, 2022
I looked into this a bit. The deal is that sometimes we don't find any sql instances here: cockroach/pkg/sql/distsql_physical_planner.go Lines 1171 to 1177 in 9e4364a
Probably we should always find ourself. That will take a tweak down in the SQLInstance layer. |
ajwerner
added a commit
to ajwerner/cockroach
that referenced
this issue
Jun 13, 2022
Touches cockroachdb#82706. Release note: None
ajwerner
added a commit
to ajwerner/cockroach
that referenced
this issue
Jun 13, 2022
Touches cockroachdb#82706. Release note: None
craig bot
pushed a commit
that referenced
this issue
Jun 13, 2022
82837: ccl/streamingccl/streamingest: skip flakey TestTenantStreaming r=ajwerner a=ajwerner Touches #82706. Release note: None Co-authored-by: Andrew Werner <[email protected]>
@rharding6373 this may be of interest to you. |
5 tasks
rharding6373
added a commit
to rharding6373/cockroach
that referenced
this issue
Jun 27, 2022
Before this change, there was a race condition where the instance provider and the instance reader would start before the instance provider created a SQL instance, potentially causing the reader to not cache the instance before initialization was complete. This is a problem in multi-tenant environments, where we may not be able to plan queries if the reader does not know of any SQL instances. This change moves sql instance initialization into the instance provider's `Start()` function before starting the reader, so that the instance is guaranteed to be visible to the reader on its first rangefeed scan of the `system.sql_instances` table. Fixes: cockroachdb#82706 Fixes: cockroachdb#81807 Fixes: cockroachdb#81567 Release note: None
rharding6373
added a commit
to rharding6373/cockroach
that referenced
this issue
Jun 29, 2022
Before this change, there was a race condition where the instance provider and the instance reader would start before the instance provider created a SQL instance, potentially causing the reader to not cache the instance before initialization was complete. This is a problem in multi-tenant environments, where we may not be able to plan queries if the reader does not know of any SQL instances. This change moves sql instance initialization into the instance provider's `Start()` function before starting the reader, so that the instance is guaranteed to be visible to the reader on its first rangefeed scan of the `system.sql_instances` table. Fixes: cockroachdb#82706 Fixes: cockroachdb#81807 Fixes: cockroachdb#81567 Release note: None
rharding6373
added a commit
to rharding6373/cockroach
that referenced
this issue
Jun 30, 2022
Before this change, there was a race condition where the instance provider and the instance reader would start before the instance provider created a SQL instance, potentially causing the reader to not cache the instance before initialization was complete. This is a problem in multi-tenant environments, where we may not be able to plan queries if the reader does not know of any SQL instances. This change moves sql instance initialization into the instance provider's `Start()` function before starting the reader, so that the instance is guaranteed to be visible to the reader on its first rangefeed scan of the `system.sql_instances` table. Fixes: cockroachdb#82706 Fixes: cockroachdb#81807 Fixes: cockroachdb#81567 Release note: None
rharding6373
added a commit
to rharding6373/cockroach
that referenced
this issue
Jun 30, 2022
Before this change, there was a race condition where the instance provider and the instance reader would start before the instance provider created a SQL instance, potentially causing the reader to not cache the instance before initialization was complete. This is a problem in multi-tenant environments, where we may not be able to plan queries if the reader does not know of any SQL instances. This change moves sql instance initialization into the instance provider's `Start()` function before starting the reader, so that the instance is guaranteed to be visible to the reader on its first rangefeed scan of the `system.sql_instances` table. Fixes: cockroachdb#82706 Fixes: cockroachdb#81807 Fixes: cockroachdb#81567 Release note: None
rharding6373
added a commit
to rharding6373/cockroach
that referenced
this issue
Jun 30, 2022
Before this change, there was a race condition where the instance provider and the instance reader would start before the instance provider created a SQL instance, potentially causing the reader to not cache the instance before initialization was complete. This is a problem in multi-tenant environments, where we may not be able to plan queries if the reader does not know of any SQL instances. This change moves sql instance initialization into the instance provider's `Start()` function before starting the reader, so that the instance is guaranteed to be visible to the reader on its first rangefeed scan of the `system.sql_instances` table. Fixes: cockroachdb#82706 Fixes: cockroachdb#81807 Fixes: cockroachdb#81567 Release note: None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
branch-master
Failures and bugs on the master branch.
C-test-failure
Broken test (automatically or manually discovered).
O-robot
Originated from a bot.
skipped-test
T-disaster-recovery
ccl/streamingccl/streamingest.TestTenantStreaming failed with artifacts on master @ e1cdb469d4828e2e1df0f801ac50d4e4f9943e1e:
Parameters:
TAGS=bazel,gss
Help
See also: How To Investigate a Go Test Failure (internal)
This test on roachdash | Improve this report!
Jira issue: CRDB-16620
The text was updated successfully, but these errors were encountered: