obsservice: connect to the sink cluster and run migrations #82695
Conversation
|
This change is |
andreimatei
force-pushed
the
obsservice.connect-sql
branch
from
0b73198 to
0df7118
Compare
There was a problem hiding this comment.
Reviewed 13 of 13 files at r1, 5 of 5 files at r2, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @abarganier)
There was a problem hiding this comment.
Nice and easy to follow!
Reviewable status:
andreimatei
force-pushed
the
obsservice.connect-sql
branch
from
0df7118 to
a766287
Compare
There was a problem hiding this comment.
bors r+
Reviewable status:
|
Build failed (retrying...): |
|
Merge conflict. |
This patch adds a --sink-pgurl flag to the obsservice for the connection string to the sink cluster. It uses it to run SQL schema migrations, of which there is a single dummy one. We're using https://github.com/pressly/goose for schema migrations; it can be used both as a cmdline binary, and as a library (we use it as a library), and it supports migrations written as either SQL files, or as a set of go functions (for the more involved ones, I guess). Release note: None
Release note: None
andreimatei
force-pushed
the
obsservice.connect-sql
branch
from
a766287 to
7e07fc1
Compare
There was a problem hiding this comment.
bors r+
Reviewable status:
|
This PR was included in a batch that was canceled, it will be automatically retried |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build succeeded: |
This patch adds a --sink-pgurl flag to the obsservice for the connection
string to the sink cluster. It uses it to run SQL schema migrations, of
which there is a single dummy one.
We're using https://github.com/pressly/goose for schema migrations;
it can be used both as a cmdline binary, and as a library (we use it
as a library), and it supports migrations written as either SQL files,
or as a set of go functions (for the more involved ones, I guess).
Release note: None