obsservice: move the http proxy to its own package

Release note: None

pkg/obsservice/cmd/obsservice/BUILD.bazel

@@ -7,7 +7,7 @@ go_library(
     visibility = ["//visibility:private"],
     deps = [
         "//pkg/cli/exit",
-        "//pkg/obsservice/obslib",
+        "//pkg/obsservice/obslib/httpproxy",
         "//pkg/obsservice/obslib/migrations",
         "@com_github_spf13_cobra//:cobra",
     ],

pkg/obsservice/cmd/obsservice/main.go

@@ -14,7 +14,7 @@ import (
 	"fmt"
 
 	"github.com/cockroachdb/cockroach/pkg/cli/exit"
-	"github.com/cockroachdb/cockroach/pkg/obsservice/obslib"
+	"github.com/cockroachdb/cockroach/pkg/obsservice/obslib/httpproxy"
 	"github.com/cockroachdb/cockroach/pkg/obsservice/obslib/migrations"
 	"github.com/spf13/cobra"
 )
@@ -27,7 +27,7 @@ var RootCmd = &cobra.Command{
 from one or more CockroachDB clusters.`,
 	Run: func(cmd *cobra.Command, args []string) {
 		ctx := context.Background()
-		cfg := obslib.ReverseHTTPProxyConfig{
+		cfg := httpproxy.ReverseHTTPProxyConfig{
 			HTTPAddr:      httpAddr,
 			TargetURL:     targetURL,
 			CACertPath:    caCertPath,
@@ -40,7 +40,7 @@ from one or more CockroachDB clusters.`,
 		}
 
 		// Block forever running the proxy.
-		<-obslib.NewReverseHTTPProxy(ctx, cfg).RunAsync(ctx)
+		<-httpproxy.NewReverseHTTPProxy(ctx, cfg).RunAsync(ctx)
 	},
 }
 

pkg/obsservice/obslib/BUILD.bazel

@@ -1,15 +0,0 @@
-load("@io_bazel_rules_go//go:def.bzl", "go_library")
-
-go_library(
-    name = "obslib",
-    srcs = ["lib.go"],
-    importpath = "github.com/cockroachdb/cockroach/pkg/obsservice/obslib",
-    visibility = ["//visibility:public"],
-    deps = [
-        "//pkg/cli/exit",
-        "//pkg/util/log",
-        "//pkg/util/syncutil",
-        "@com_github_cockroachdb_cmux//:cmux",
-        "@com_github_cockroachdb_errors//:errors",
-    ],
-)

pkg/obsservice/obslib/httpproxy/BUILD.bazel

@@ -0,0 +1,15 @@
+load("@io_bazel_rules_go//go:def.bzl", "go_library")
+
+go_library(
+    name = "httpproxy",
+    srcs = ["reverseproxy.go"],
+    importpath = "github.com/cockroachdb/cockroach/pkg/obsservice/obslib/httpproxy",
+    visibility = ["//visibility:public"],
+    deps = [
+        "//pkg/cli/exit",
+        "//pkg/util/log",
+        "//pkg/util/syncutil",
+        "@com_github_cockroachdb_cmux//:cmux",
+        "@com_github_cockroachdb_errors//:errors",
+    ],
+)

pkg/obsservice/obslib/lib.go → pkg/obsservice/obslib/httpproxy/reverseproxy.go

@@ -6,7 +6,7 @@
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 
-package obslib
+package httpproxy
 
 import (
 	"context"