Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ppc64le - fix test failures of TestBoundingBoxFromGeomT/GeographyType #81734

Merged
merged 3 commits into from
May 27, 2022

Conversation

prashantkhoje
Copy link
Contributor

Allow floating point approximation within an epsilon
Fixes #81733

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented May 24, 2022

CLA assistant check
All committers have signed the CLA.

@blathers-crl
Copy link

blathers-crl bot commented May 24, 2022

Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR.

Before a member of our team reviews your PR, I have some potential action items for you:

  • Please ensure your git commit message contains a release note.
  • When CI has completed, please ensure no errors have appeared.

I was unable to automatically find a reviewer. You can try CCing one of the following members:

  • A person you worked with closely on this PR.
  • The person who created the ticket, or a CRDB organization member involved with the ticket (author, commenter, etc.).
  • Join our community slack channel and ask on #contributors.
  • Try find someone else from here.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@blathers-crl blathers-crl bot added O-community Originated from the community X-blathers-untriaged blathers was unable to find an owner labels May 24, 2022
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@prashantkhoje
Copy link
Contributor Author

I referred #66621.

@blathers-crl
Copy link

blathers-crl bot commented May 26, 2022

Thank you for updating your pull request.

Before a member of our team reviews your PR, I have some potential action items for you:

  • We notice you have more than one commit in your PR. We try break logical changes into separate commits, but commits such as "fix typo" or "address review commits" should be squashed into one commit and pushed with --force
  • Please ensure your git commit message contains a release note.
  • When CI has completed, please ensure no errors have appeared.

I have added a few people who may be able to assist in reviewing:

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@blathers-crl blathers-crl bot added the X-blathers-triaged blathers was able to find an owner label May 26, 2022
@blathers-crl blathers-crl bot requested a review from otan May 26, 2022 11:26
@blathers-crl
Copy link

blathers-crl bot commented May 26, 2022

Thank you for updating your pull request.

Before a member of our team reviews your PR, I have some potential action items for you:

  • We notice you have more than one commit in your PR. We try break logical changes into separate commits, but commits such as "fix typo" or "address review commits" should be squashed into one commit and pushed with --force
  • Please ensure your git commit message contains a release note.
  • When CI has completed, please ensure no errors have appeared.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@prashantkhoje
Copy link
Contributor Author

@otan, please review.

@otan
Copy link
Contributor

otan commented May 27, 2022

bors r+

@craig
Copy link
Contributor

craig bot commented May 27, 2022

Build succeeded:

@craig craig bot merged commit 1047fb0 into cockroachdb:master May 27, 2022
@prashantkhoje prashantkhoje deleted the ppc64le branch June 1, 2022 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-community Originated from the community X-blathers-triaged blathers was able to find an owner X-blathers-untriaged blathers was unable to find an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PPC64LE - pkg/geo - TestBoundingBoxFromGeomT - Test failures due to floating point differences
3 participants