geo: prepare for passing ARM tests #66621
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release note (bug fix): Fix a bug where a substring of a linestring with the same points would return EMPTY instead of a POINT with the repeated point. Release note (bug fix): Fix a bug where it is possible for a linestring returned from ST_LineSubString to have repeated points.
|
This change is |
ARM seems to round differently to results we typically have. To support this, we should use epsilon comparisons more often. We move some of this functionality to a `geotest` package. We also have to write our own `InEpsilon`, as this require.InEpsilon will fail if 0 is used as an expected value. This gets everything except for the geoindex tests that failed [here](https://teamcity.cockroachdb.com/buildConfiguration/Cockroach_UnitTests_RickyTestForArm/3095227). Release note: None
This allows a small epsilon for test results. Release note: None
otan
changed the title
|
pausing development on this for now! if ARM turns out to be a requirement i'll revive this. |
|
I can see approximation allowed for s390x at 688583e |
prashantkhoje
added a commit
to prashantkhoje/cockroach
that referenced
this pull request
Jun 2, 2022
geogfn
- TestAzimuth/north_east
- TestSegmentize/LINESTRING(1.0_1.0,_2.0_2.0,_3.0_3.0),_maximum_segment_length:_100000.000000
- TestSegmentize/POLYGON((0.0_0.0,_1.0_0.0,_1.0_1.0,_0.0_0.0)),_maximum_segment_length:_100000.000000
- TestSegmentize/POLYGON((0.0_0.0,_1.0_0.0,_1.0_1.0,_0.0_0.0),_(0.1_0.1,_0.2_0.1,_0.2_0.2,_0.1_0.1)),_maximum_segment_length:_50000.000000
- TestSegmentize/MULTILINESTRING((1.0_1.0,_2.0_2.0,_3.0_3.0),_(6.0_6.0,_7.0_6.0)),_maximum_segment_length:_100000.000000
- TestSegmentize/MULTILINESTRING_(EMPTY,_(1.0_1.0,_2.0_2.0,_3.0_3.0),_(6.0_6.0,_7.0_6.0)),_maximum_segment_length:_100000.000000
- TestSegmentize/MULTIPOLYGON(((3.0_3.0,_4.0_3.0,_4.0_4.0,_3.0_3.0)),_((0.0_0.0,_1.0_0.0,_1.0_1.0,_0.0_0.0),_(0.1_0.1,_0.2_0.1,_0.2_0.2,_0.1_0.1))),_maximum_segment_length:_100000.000000
- TestSegmentize/GEOMETRYCOLLECTION_(POINT_(40_10),LINESTRING_(10_10,_20_20,_10_40),POLYGON_((40_40,_20_45,_45_30,_40_40))),_maximum_segment_length:_1000000.000000
- TestSegmentize/LINESTRING(0_0_25,_0_1_0,_2_5_100),_maximum_segment_length:_150000.000000
- TestSegmentizeCoords/Coordinate(85,_85)_to_Coordinate(0,_0),_0.29502092024628396
- TestSegmentizeCoords/Coordinate(0,_16,_23,_10)_to_Coordinate(1,_0,_-5,_0),_0.07848050723825097
- TestProject/SRID
geomfn - TestGenerateRandomPoints/Polygon_with_a_hole
Cherry picks cockroachdb#66621
Release note: None
Co-authored-by: Oliver Tan <[email protected]>
craig bot
pushed a commit
that referenced
this pull request
Jun 2, 2022
82250: ppc64le - fix geogfn and geomfn test failures r=otan a=prashantkhoje
geogfn
- TestAzimuth/north_east
- TestSegmentize/LINESTRING(1.0_1.0,_2.0_2.0,_3.0_3.0),_maximum_segment_length:_100000.000000
- TestSegmentize/POLYGON((0.0_0.0,_1.0_0.0,_1.0_1.0,_0.0_0.0)),_maximum_segment_length:_100000.000000
- TestSegmentize/POLYGON((0.0_0.0,_1.0_0.0,_1.0_1.0,_0.0_0.0),_(0.1_0.1,_0.2_0.1,_0.2_0.2,_0.1_0.1)),_maximum_segment_length:_50000.000000
- TestSegmentize/MULTILINESTRING((1.0_1.0,_2.0_2.0,_3.0_3.0),_(6.0_6.0,_7.0_6.0)),_maximum_segment_length:_100000.000000
- TestSegmentize/MULTILINESTRING_(EMPTY,_(1.0_1.0,_2.0_2.0,_3.0_3.0),_(6.0_6.0,_7.0_6.0)),_maximum_segment_length:_100000.000000
- TestSegmentize/MULTIPOLYGON(((3.0_3.0,_4.0_3.0,_4.0_4.0,_3.0_3.0)),_((0.0_0.0,_1.0_0.0,_1.0_1.0,_0.0_0.0),_(0.1_0.1,_0.2_0.1,_0.2_0.2,_0.1_0.1))),_maximum_segment_length:_100000.000000
- TestSegmentize/GEOMETRYCOLLECTION_(POINT_(40_10),LINESTRING_(10_10,_20_20,_10_40),POLYGON_((40_40,_20_45,_45_30,_40_40))),_maximum_segment_length:_1000000.000000
- TestSegmentize/LINESTRING(0_0_25,_0_1_0,_2_5_100),_maximum_segment_length:_150000.000000
- TestSegmentizeCoords/Coordinate(85,_85)_to_Coordinate(0,_0),_0.29502092024628396
- TestSegmentizeCoords/Coordinate(0,_16,_23,_10)_to_Coordinate(1,_0,_-5,_0),_0.07848050723825097
- TestProject/SRID
geomfn - TestGenerateRandomPoints/Polygon_with_a_hole
Cherry picks #66621
Release note: None
Co-authored-by: Oliver Tan <[email protected]>
82366: backupccl: remove destination resolution during planning r=benbardin a=adityamaru
Release note: None
Co-authored-by: Prashant Khoje <[email protected]>
Co-authored-by: Aditya Maru <[email protected]>
prashantkhoje
added a commit
to prashantkhoje/cockroach
that referenced
this pull request
Jun 5, 2022
…stS2GeometryIndexBasic Cherry picks cockroachdb#66621 Release note: None Co-authored-by: Oliver Tan [email protected]
craig bot
pushed a commit
that referenced
this pull request
Jun 5, 2022
82456: ppc64le - fix geoindex test failures TestS2GeographyIndexBasic and TestS2GeometryIndexBasic r=otan a=prashantkhoje Cherry picks #66621 Release note: None Co-authored-by: Oliver Tan [email protected] Co-authored-by: Prashant Khoje <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits for details
cc @rickystewart