ui: Plot circuit breaker tripped events as a rate values

[koorosh]

Resolves #78939

Before, Circuit Breaker Tripped events chart displayed the accumulated number
of events since the process started.

Now, it displays the number of events per aggregated interval of time.

Release note (ui change): Circuit Breaker Tripped events chart displays
rate of events per interval instead of the accumulated number of events.

[cockroach-teamcity]

This change is 

[tbg]

Looks good mod the comment Help in metrics.go, thanks!

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @koorosh)

---

pkg/kv/kvserver/metrics.go line 1407 at r1 (raw file):

	metaReplicaCircuitBreakerCumTripped = metric.Metadata{
		Name:        "kv.replica_circuit_breaker.num_tripped_events",
		Help:        `The number of circuit breaker events occurred per second across all nodes since the process started.`,

This isn't "across all nodes", each metric counter is local to a store and thus will be reported at the store level. It just so happens that the chart we later expose in the DB console aggregates over all stores. So the comment in graphTooltips.tsx is correct. Also, this here is still a counter, not a rate. We only compute a rate in the console.

[koorosh]

Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @tbg)

---

pkg/kv/kvserver/metrics.go line 1407 at r1 (raw file):

Previously, tbg (Tobias Grieger) wrote…

This isn't "across all nodes", each metric counter is local to a store and thus will be reported at the store level. It just so happens that the chart we later expose in the DB console aggregates over all stores. So the comment in graphTooltips.tsx is correct. Also, this here is still a counter, not a rate. We only compute a rate in the console.

gotcha, then I tend to revert back this Help message because it also doesn't count "per second".

[koorosh]

bors r+

[craig]

Build failed (retrying...):

• GitHub CI (Cockroach)

[rickystewart]

bors r-

[craig]

Canceled.

[rickystewart]

bors r=tbg

Sorry, needed to cancel this run to move bors along.

[craig]

Build succeeded:

• GitHub CI (Cockroach)