Skip to content

Commit

Permalink
ui: Plot circuit breaker tripped events as a rate values
Browse files Browse the repository at this point in the history
Before, Circuit Breaker Tripped events chart displayed accumulated number
of events since process started.

Now, it displays number of events per aggregated interval of time.

Release note (ui change): Circuit Breaker Tripped events chart displays
rate of events per interval instead of accumulated number of events.
  • Loading branch information
koorosh committed May 18, 2022
1 parent 2d53147 commit 361bfd0
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion pkg/kv/kvserver/metrics.go
Original file line number Diff line number Diff line change
Expand Up @@ -1404,7 +1404,7 @@ Replicas in this state will fail-fast all inbound requests.
// Replica circuit breaker.
metaReplicaCircuitBreakerCumTripped = metric.Metadata{
Name: "kv.replica_circuit_breaker.num_tripped_events",
Help: `Number of times the per-Replica circuit breakers tripped since process start.`,
Help: `The number of circuit breaker events occurred per second across all nodes since the process started.`,
Measurement: "Events",
Unit: metric.Unit_COUNT,
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ export const CircuitBreakerTrippedReplicasTooltip: React.FC = () => (

export const CircuitBreakerTrippedEventsTooltip: React.FC = () => (
<div>
Number of times the per-Replica circuit breakers tripped since process
start.
The number of circuit breaker events occurred per second across all
nodes since the process started.
</div>
);
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ export default function(props: GraphDashboardProps) {
name="cr.store.kv.replica_circuit_breaker.num_tripped_events"
title={nodeDisplayName(nodesSummary, nid)}
sources={storeIDsForNode(nodesSummary, nid)}
downsampler={TimeSeriesQueryAggregator.MAX}
nonNegativeRate
/>
))}
</Axis>
Expand Down

0 comments on commit 361bfd0

Please sign in to comment.